Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reason of conflicting settings message from Ginkgo library #200

Conversation

jaroslaw-pieszka
Copy link
Contributor

Description

We set verbosity for Ginkgo library in ReconfigureGinkgo based on env variable setting.
Additional assignment allows to set verbosity to two different levels and that causes Ginkgo library to report conflicting settings.

Changes proposed in this pull request:

  • removal of accidentally added assignment

Related issue(s)

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner March 1, 2023 09:24
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2023
@jaroslaw-pieszka jaroslaw-pieszka force-pushed the removing_conficting_ginkgo_verbosity_settings branch from 9156309 to ef691f6 Compare March 1, 2023 09:29
@CLAassistant
Copy link

CLAassistant commented Mar 1, 2023

CLA assistant check
All committers have signed the CLA.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 1, 2023
@jaroslaw-pieszka
Copy link
Contributor Author

/retest

@kyma-bot kyma-bot merged commit 4b78710 into kyma-project:main Mar 2, 2023
@jaroslaw-pieszka jaroslaw-pieszka deleted the removing_conficting_ginkgo_verbosity_settings branch April 5, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants