Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logo title not announced entirely #3403

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: logo title not announced entirely #3403

wants to merge 7 commits into from

Conversation

chriskari
Copy link
Contributor

@chriskari chriskari commented Oct 14, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • fixed logo title being announced entirely
  • fixed no visible label for search input after user types

Related issue(s)
#3135

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 14, 2024
@chriskari chriskari linked an issue Oct 14, 2024 that may be closed by this pull request
ACC-255.5 (Level AA), ACC-264.1 (Level A) _ Modify Modules _ Image of text _ Text alt not descriptive and text within image not read #3135
Open
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 14, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 15, 2024
@chriskari chriskari linked an issue Oct 15, 2024 that may be closed by this pull request
ACC-253.1 (Level AA) _ Modify Modules _ Edit field _ No visible label provided #3125
Open
@dbadura dbadura self-assigned this Oct 16, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2024
dbadura
dbadura requested changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@dbadura dbadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How fixed no visible label for search input after user types are related to incorrect sap logo text?

@dbadura dbadura assigned chriskari and unassigned dbadura Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbadura dbadura dbadura requested changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@chriskari chriskari

Labels
cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@chriskari @dbadura @kyma-bot