Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch IOP to new structure #1192

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Switch IOP to new structure #1192

wants to merge 12 commits into from

Conversation

barchw
Copy link
Contributor

@barchw barchw commented Dec 12, 2024

Description

Changes proposed in this pull request:

  • Switch IOP to new structure

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

@barchw barchw requested a review from a team as a code owner December 12, 2024 13:48
@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 12, 2024
@barchw barchw changed the title wip: switch IOP to new structure Switch IOP to new structure Dec 16, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 16, 2024
Comment on lines +27 to +36
istio.io/api v1.24.0-rc.0.0.20241101200753-9397ebf09c3a
istio.io/client-go v1.24.0
istio.io/istio v0.0.0-20241105211601-8825a6b7f8c9
k8s.io/api v0.31.1
k8s.io/apiextensions-apiserver v0.31.1
k8s.io/apimachinery v0.31.1
k8s.io/client-go v0.31.1
k8s.io/kubectl v0.31.1
k8s.io/utils v0.0.0-20240921022957-49e7df575cb6
sigs.k8s.io/controller-runtime v0.19.3 // Since we are using the Istio library directly, we should also use the controller-runtime version that is used by Istio.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an officially tagged version available 1.24.1? this one seems to be a release-candidate for 1.24.0.

Copy link
Contributor Author

@barchw barchw Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what Istio uses in the 1.24.1 tag. That's usually how it is 😢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants