Skip to content
Lint golangci

chore: Refactor manifest reconciler #3883

Sign in to view logs

chore: Refactor manifest reconciler

chore: Refactor manifest reconciler #3883

Triggered via pull request October 17, 2024 11:37
@ruanxinruanxin
opened #1967
ruanxin:refactor-manifest-reconciler
Status Failure
Total duration 4m 12s
Artifacts –

lint-golangci.yml

on: pull_request
lint
4m 1s
lint
Fit to window
Zoom out
Zoom in

Annotations

10 errors
lint: internal/controller/manifest/controller.go#L6
could not import github.com/kyma-project/lifecycle-manager/internal/declarative/v2 (-: import cycle not allowed: import stack: [github.com/kyma-project/lifecycle-manager/cmd github.com/kyma-project/lifecycle-manager/internal/controller/manifest github.com/kyma-project/lifecycle-manager/internal/declarative/v2 github.com/kyma-project/lifecycle-manager/internal/manifest/modulecr github.com/kyma-project/lifecycle-manager/internal/declarative/v2]) (typecheck)
lint: internal/declarative/v2/default_transforms_test.go#L4
"context" imported and not used (typecheck)
lint: internal/declarative/v2/default_transforms_test.go#L12
could not import github.com/kyma-project/lifecycle-manager/internal/declarative/v2 (-: import cycle not allowed in test) (typecheck)
lint: internal/manifest/client.go#L19
"github.com/kyma-project/lifecycle-manager/api/v1beta2" imported and not used (typecheck)
lint: internal/manifest/client.go#L21
could not import github.com/kyma-project/lifecycle-manager/internal/declarative/v2 (-: import cycle not allowed: import stack: [github.com/kyma-project/lifecycle-manager/cmd github.com/kyma-project/lifecycle-manager/internal/controller/manifest github.com/kyma-project/lifecycle-manager/internal/declarative/v2 github.com/kyma-project/lifecycle-manager/internal/manifest/modulecr github.com/kyma-project/lifecycle-manager/internal/declarative/v2]) (typecheck)
lint: internal/manifest/modulecr/client.go#L16
could not import github.com/kyma-project/lifecycle-manager/internal/declarative/v2 (-: import cycle not allowed: import stack: [github.com/kyma-project/lifecycle-manager/cmd github.com/kyma-project/lifecycle-manager/internal/controller/manifest github.com/kyma-project/lifecycle-manager/internal/declarative/v2 github.com/kyma-project/lifecycle-manager/internal/manifest/modulecr github.com/kyma-project/lifecycle-manager/internal/declarative/v2]) (typecheck)
lint: internal/manifest/spec_resolver_test.go#L15
could not import github.com/kyma-project/lifecycle-manager/internal/declarative/v2 (-: import cycle not allowed: import stack: [github.com/kyma-project/lifecycle-manager/cmd github.com/kyma-project/lifecycle-manager/internal/controller/manifest github.com/kyma-project/lifecycle-manager/internal/declarative/v2 github.com/kyma-project/lifecycle-manager/internal/manifest/modulecr github.com/kyma-project/lifecycle-manager/internal/declarative/v2]) (typecheck)
lint: tests/integration/controller/manifest/custom_resource_check/suite_test.go#L43
could not import github.com/kyma-project/lifecycle-manager/internal/declarative/v2 (-: import cycle not allowed: import stack: [github.com/kyma-project/lifecycle-manager/cmd github.com/kyma-project/lifecycle-manager/internal/controller/manifest github.com/kyma-project/lifecycle-manager/internal/declarative/v2 github.com/kyma-project/lifecycle-manager/internal/manifest/modulecr github.com/kyma-project/lifecycle-manager/internal/declarative/v2]) (typecheck)
lint: tests/integration/controller/manifest/ready_check_test.go#L18
could not import github.com/kyma-project/lifecycle-manager/internal/declarative/v2 (-: import cycle not allowed: import stack: [github.com/kyma-project/lifecycle-manager/cmd github.com/kyma-project/lifecycle-manager/internal/controller/manifest github.com/kyma-project/lifecycle-manager/internal/declarative/v2 github.com/kyma-project/lifecycle-manager/internal/manifest/modulecr github.com/kyma-project/lifecycle-manager/internal/declarative/v2]) (typecheck)
lint
issues found