Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose watcher Chart config to Kyma API #296

Open
4 tasks
Tracked by #776
fourthisle opened this issue Nov 3, 2022 · 10 comments
Open
4 tasks
Tracked by #776

Expose watcher Chart config to Kyma API #296

fourthisle opened this issue Nov 3, 2022 · 10 comments
Labels
API Denotes that an issue is tied to the potential change of the API area/quality Related to all activites around quality

Comments

@fourthisle
Copy link
Contributor

fourthisle commented Nov 3, 2022

Description

Currently, We adapt an Kyma CR agnostic solution for the SKR watcher web-hook chart (which is configurable with deployment flags). As in general if we have a setting in the runtime we should always expose it in the API if its not a technical derivate and fill it with nice defaults. that way we can also mitigate single clusters later on if we spot anomalies.

ACs

  • Expose SkrChartConfig in Kyma CR spec instead of using deployment flags.
  • Refactor SKRWebhookChartManager implementation to use config from kyma CR specs.
  • Configure the same default values for the Chart config used for deployment flags
  • Provide an automated test with the dual-cluster setup

Related discussions
#277 (comment)

@fourthisle fourthisle changed the title Expose watcher Chart config to Kyma API Expose watcher Chart config to Kyma API and reuse sync context when installing skr chart Nov 3, 2022
@fourthisle fourthisle changed the title Expose watcher Chart config to Kyma API and reuse sync context when installing skr chart Expose watcher Chart config to Kyma API and pass sync context when creating skr chart manager Nov 8, 2022
@fourthisle fourthisle changed the title Expose watcher Chart config to Kyma API and pass sync context when creating skr chart manager Expose watcher Chart config to Kyma API Nov 16, 2022
@kyma-bot
Copy link
Contributor

kyma-bot commented Feb 3, 2023

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 3, 2023
@janmedrek janmedrek removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 9, 2023
@fourthisle
Copy link
Contributor Author

Blocked until watcher is released, as API version upgrades should be decoupled from watcher release.

@kyma-bot
Copy link
Contributor

kyma-bot commented Jun 2, 2023

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 2, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Jun 9, 2023

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

@kyma-bot
Copy link
Contributor

kyma-bot commented Jun 9, 2023

@kyma-bot: Closing this issue.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot closed this as completed Jun 9, 2023
@fourthisle fourthisle reopened this Jun 12, 2023
@fourthisle
Copy link
Contributor Author

/remove-lifecycle stale

@kyma-bot kyma-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 12, 2023
@janmedrek janmedrek added the API Denotes that an issue is tied to the potential change of the API label Aug 2, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 1, 2023

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 1, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 8, 2023

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 8, 2023

@kyma-bot: Closing this issue.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kyma-bot kyma-bot closed this as completed Oct 8, 2023
@janmedrek janmedrek removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 8, 2023
@janmedrek janmedrek reopened this Oct 8, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Dec 7, 2023

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 7, 2023
@janmedrek janmedrek added area/quality Related to all activites around quality and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Denotes that an issue is tied to the potential change of the API area/quality Related to all activites around quality
Projects
None yet
Development

No branches or pull requests

3 participants