Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config layer #543

Closed
5 tasks done
Tracked by #776
ruanxin opened this issue Apr 20, 2023 · 3 comments · Fixed by kyma-project/cli#1712 or #786
Closed
5 tasks done
Tracked by #776

Remove config layer #543

ruanxin opened this issue Apr 20, 2023 · 3 comments · Fixed by kyma-project/cli#1712 or #786
Assignees
Labels
API Denotes that an issue is tied to the potential change of the API

Comments

@ruanxin
Copy link
Contributor

ruanxin commented Apr 20, 2023

Since now we only support raw manifest rendering, the config layer which was previously provided as helm chart, kustomize overwrite becomes useless. We should remove any config.yaml related code in lifecycle manager.

AC:

  • CLI don't need to handle config.yaml, and generated module template should not contains config layer.
  • Drop the code from the CLI related to the config layer
  • For module template which contains config, the config layer will not rendered into manifest CR.
  • All code in lifecycle manager related handling this config should be removed
  • Update the description in the ModuleTemplate CRD to indicate that the config field is no longer used

Be aware, eventually, manifest spec should not contain this config field, but this might introduce breaking changes, should plan it in next API version. In this issue, don't remove this Config field.

type ManifestSpec struct {
	// Config specifies OCI image configuration for Manifest
	Config ImageSpec `json:"config,omitempty"`

@kyma-bot
Copy link
Contributor

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 19, 2023
@janmedrek janmedrek removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 20, 2023
@janmedrek janmedrek added API Denotes that an issue is tied to the potential change of the API and removed API Denotes that an issue is tied to the potential change of the API labels Jul 20, 2023
@janmedrek
Copy link
Contributor

The CLI part is already done with the new way of building the Modules (based on the config file and not the kubebuilder repo).

@janmedrek janmedrek added the API Denotes that an issue is tied to the potential change of the API label Jul 20, 2023
@LeelaChacha LeelaChacha self-assigned this Jul 24, 2023
@LeelaChacha LeelaChacha removed their assignment Jul 31, 2023
LeelaChacha added a commit to LeelaChacha/kyma-lifecycle-manager that referenced this issue Aug 2, 2023
…config-layer' into feature/kyma-project#543-remove-config-layer

# Conflicts:
#	controllers/moduletemplate_test.go
LeelaChacha added a commit to LeelaChacha/kyma-lifecycle-manager that referenced this issue Aug 8, 2023
LeelaChacha added a commit to LeelaChacha/kyma-lifecycle-manager that referenced this issue Aug 8, 2023
…config-layer' into feature/kyma-project#543-remove-config-layer

# Conflicts:
#	controllers/moduletemplate_test.go
@LeelaChacha LeelaChacha reopened this Aug 9, 2023
@LeelaChacha
Copy link
Contributor

One PR is still left

LeelaChacha added a commit to LeelaChacha/kyma-lifecycle-manager that referenced this issue Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Denotes that an issue is tied to the potential change of the API
Projects
None yet
4 participants