Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor NewCachedDescriptorProvider (#1695) #1700

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

ruanxin
Copy link
Contributor

@ruanxin ruanxin commented Jul 18, 2024

  • remove parameter for NewCachedDescriptorProvider

  • fix dead link

  • adjust unit test coverage

  • fix flaky test

Description

Changes proposed in this pull request:

  • ...
  • ...
  • ...

Related issue(s)

* remove parameter for NewCachedDescriptorProvider

* fix dead link

* adjust unit test coverage

* fix flaky test
@ruanxin ruanxin requested review from a team as code owners July 18, 2024 18:22
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 19, 2024
@kyma-bot kyma-bot merged commit dda2432 into feat/module-catalogue-improvements Jul 19, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants