Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make spec_resolver.go testable #1827

Merged

Conversation

Tomasz-Smelcerz-SAP
Copy link
Member

Description

Fixes: #1781

Changes proposed in this pull request:

  • code refactor
  • simple unit test

Related issue(s)
#1781

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP requested a review from a team as a code owner September 4, 2024 06:12
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 4, 2024
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP added the area/quality Related to all activites around quality label Sep 4, 2024
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP force-pushed the chore/testable-spec-resolver branch 2 times, most recently from deba9cf to 709991f Compare September 4, 2024 08:06
jeremyharisch
jeremyharisch previously approved these changes Sep 4, 2024
@kyma-bot kyma-bot added lgtm Looks good to me! and removed lgtm Looks good to me! labels Sep 4, 2024
docs: Add code of conduct and update README.md (kyma-project#1826)

* docs: Add code of conduct and update README.md

* Fix file name
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 5, 2024
@kyma-bot kyma-bot merged commit 2ce8b53 into kyma-project:main Sep 5, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Related to all activites around quality cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make spec_resolver.go testable
3 participants