Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add new Panel to display Modules in Error State #1873

Merged
merged 1 commit into from
Sep 17, 2024
Merged

feat: Add new Panel to display Modules in Error State #1873

merged 1 commit into from
Sep 17, 2024

Conversation

amritanshusikdar
Copy link
Contributor

Description

Changes proposed in this pull request:
A new panel in the Plutono dashboard under Lifecycle Manager Kyma Status to display the Modules which are in Error state.

Related issue(s)
Resolves #1745

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@amritanshusikdar amritanshusikdar marked this pull request as ready for review September 17, 2024 12:05
@amritanshusikdar amritanshusikdar requested a review from a team as a code owner September 17, 2024 12:05
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 17, 2024
@amritanshusikdar
Copy link
Contributor Author

For now as of this initial commit, the result looks identical to what's been expected in the issue as AC.

But upon fiddling around with the dashboard and several queries, I felt this view is more concise, if we toggle the Instant switch on. It delivers the information in short, which Kymas are affected, and which modules in those Kymas are in error state. Also saves you from wrist pain of endless scrolling.

image

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 17, 2024
@amritanshusikdar amritanshusikdar merged commit 9896fab into kyma-project:main Sep 17, 2024
60 checks passed
@amritanshusikdar amritanshusikdar deleted the plutono-error-manifest-panel branch September 19, 2024 08:32
nesmabadr added a commit to nesmabadr/lifecycle-manager that referenced this pull request Oct 4, 2024
@nesmabadr
Revert "feat: Add new Panel to display Modules in Error State (kyma-p…
9928dd4 
…roject#1873)"

This reverts commit 9896fab.
lindnerby pushed a commit that referenced this pull request Oct 4, 2024
@nesmabadr
chore: Revert "feat: Add new Panel to display Modules in Error State (#…
99a66ec 
…1873)" (#1927)

Revert "feat: Add new Panel to display Modules in Error State (#1873)"

This reverts commit 9896fab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyharisch jeremyharisch jeremyharisch approved these changes

Assignees

@jeremyharisch jeremyharisch

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a new panel to show all Manifest CR in error state
3 participants
@amritanshusikdar @kyma-bot @jeremyharisch