Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove managed-by label when module is unmanaged #1913

Merged
merged 36 commits into from
Oct 11, 2024

Conversation

nesmabadr
Copy link
Contributor

@nesmabadr nesmabadr commented Oct 2, 2024

Description

Changes proposed in this pull request:

  • Remove managed-by label when module is unmanaged
  • Add unit and E2E tests

Related issue(s)
Resolves #1823

@nesmabadr nesmabadr added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2024
@nesmabadr nesmabadr requested a review from a team as a code owner October 2, 2024 11:49
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 2, 2024
@nesmabadr nesmabadr changed the title feat:Remove managed-by and watched-by labels when module is unmanaged feat: Remove managed-by and watched-by labels when module is unmanaged Oct 2, 2024
@nesmabadr nesmabadr changed the title feat: Remove managed-by and watched-by labels when module is unmanaged feat: Remove managed-by labels when module is unmanaged Oct 10, 2024
@nesmabadr nesmabadr changed the title feat: Remove managed-by labels when module is unmanaged feat: Remove managed-by label when module is unmanaged Oct 10, 2024
internal/manifest/labelsremoval/labels_removal.go Outdated Show resolved Hide resolved
internal/manifest/labelsremoval/labels_removal_test.go Outdated Show resolved Hide resolved
internal/manifest/labelsremoval/labels_removal.go Outdated Show resolved Hide resolved
internal/manifest/labelsremoval/labels_removal.go Outdated Show resolved Hide resolved
unit-test-coverage.yaml Outdated Show resolved Hide resolved
@nesmabadr nesmabadr force-pushed the remove_labels_unmanaged branch 7 times, most recently from ed4223b to d2eef41 Compare October 10, 2024 14:53
@lindnerby lindnerby enabled auto-merge (squash) October 11, 2024 05:46
internal/declarative/v2/reconciler.go Outdated Show resolved Hide resolved
internal/declarative/v2/reconciler.go Outdated Show resolved Hide resolved
internal/manifest/labelsremoval/labels_removal.go Outdated Show resolved Hide resolved
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 11, 2024
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 11, 2024
@lindnerby lindnerby merged commit 6574450 into kyma-project:main Oct 11, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop labels when the module is unmanaged
3 participants