Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add docs for unmanaging modules #1936

Merged
merged 7 commits into from
Oct 9, 2024
Merged

docs: Add docs for unmanaging modules #1936

merged 7 commits into from
Oct 9, 2024

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Oct 7, 2024

Description

Changes proposed in this pull request:

  • Adds documentation for the managed field in contributor docs
  • References the whole Kyma contributor doc from Kyma user doc.

Related issue(s)

@c-pius c-pius requested a review from a team as a code owner October 7, 2024 13:16
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 7, 2024
mmitoraj
mmitoraj reviewed Oct 8, 2024
View reviewed changes
docs/contributor/resources/01-kyma.md Outdated Show resolved Hide resolved
docs/contributor/resources/01-kyma.md Outdated Show resolved Hide resolved
docs/contributor/resources/01-kyma.md Outdated Show resolved Hide resolved
docs/contributor/resources/01-kyma.md Outdated Show resolved Hide resolved
docs/user/01-10-kyma-crd.md Outdated Show resolved Hide resolved
@c-pius
Copy link
Contributor Author

c-pius commented Oct 8, 2024

TODOs:

  • explain the monitoring implications
  • explain the support/SLA implications

c-pius and others added 2 commits October 8, 2024 15:17
@c-pius
docs: Add docs for unmanaging modules
64224bc
@c-pius @mmitoraj
Suggestions Gosia
707174d 
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
mmitoraj
mmitoraj reviewed Oct 8, 2024
View reviewed changes
docs/contributor/resources/01-kyma.md Outdated Show resolved Hide resolved
docs/contributor/resources/01-kyma.md Outdated Show resolved Hide resolved
docs/contributor/resources/01-kyma.md Outdated Show resolved Hide resolved
docs/contributor/resources/01-kyma.md Show resolved Hide resolved
docs/contributor/resources/01-kyma.md Outdated Show resolved Hide resolved
c-pius and others added 2 commits October 9, 2024 07:15
@c-pius @mmitoraj
Suggestions Gosia
ab834fd 
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
@c-pius
move caution under relevant section
113bfc4
@c-pius c-pius requested a review from mmitoraj October 9, 2024 05:24
@c-pius @mmitoraj
Suggestion Gosia
11e7ed2 
Co-authored-by: Małgorzata Świeca <malgorzata.swieca@sap.com>
@c-pius c-pius requested a review from nesmabadr October 9, 2024 07:21
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 9, 2024
@c-pius c-pius merged commit 00de055 into kyma-project:main Oct 9, 2024
34 checks passed
@c-pius c-pius deleted the docs/unmanaging-modules branch October 9, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesmabadr nesmabadr nesmabadr approved these changes

@mmitoraj mmitoraj mmitoraj approved these changes

Assignees

@nesmabadr nesmabadr

@mmitoraj mmitoraj

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare a document on how to unmanage modules
4 participants
@c-pius @nesmabadr @mmitoraj @kyma-bot