Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniformity in Testing Patterns #48

Open
2 tasks
amritanshusikdar opened this issue Sep 9, 2024 · 0 comments
Open
2 tasks

Uniformity in Testing Patterns #48

amritanshusikdar opened this issue Sep 9, 2024 · 0 comments
Labels
area/quality enhancement New feature or request question Further information is requested

Comments

@amritanshusikdar
Copy link
Contributor

Description
The testing patterns in this repository have been a bit inconsistent. We're specifically talking about unit testing here. Below is an instance:

  • The scaffold validate() function is package private because it is used only for the scaffold command as an internal functionality. But this takes away from the unit testability:
    • This function is hence tested here
  • The new create command layer also has a Validate() function, which in contrast to the scaffold command is public and includes a corresponding options_test.go file with unit tests solely for this function.

Reasons

  • There should be consistency with the testing patterns
  • There should be uniformity across team ideologies, hence something like this could also be implemented here

Acceptance Criteria

  • The unit tests for scaffold command are adjusted to follow the same pattern as the create command
  • Appropriate changes are done in the e2e tests as well
@amritanshusikdar amritanshusikdar added enhancement New feature or request question Further information is requested area/quality labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant