You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
The testing patterns in this repository have been a bit inconsistent. We're specifically talking about unit testing here. Below is an instance:
The scaffold validate() function is package private because it is used only for the scaffold command as an internal functionality. But this takes away from the unit testability:
The new create command layer also has a Validate() function, which in contrast to the scaffold command is public and includes a corresponding options_test.go file with unit tests solely for this function.
Reasons
There should be consistency with the testing patterns
There should be uniformity across team ideologies, hence something like this could also be implemented here
Acceptance Criteria
The unit tests for scaffold command are adjusted to follow the same pattern as the create command
Appropriate changes are done in the e2e tests as well
The text was updated successfully, but these errors were encountered:
Description
The testing patterns in this repository have been a bit inconsistent. We're specifically talking about unit testing here. Below is an instance:
validate()
function is package private because it is used only for the scaffold command as an internal functionality. But this takes away from the unit testability:Validate()
function, which in contrast to the scaffold command is public and includes a correspondingoptions_test.go
file with unit tests solely for this function.Reasons
Acceptance Criteria
scaffold
command are adjusted to follow the same pattern as thecreate
commandThe text was updated successfully, but these errors were encountered: