Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Only check for test changes if there are also code changes #1806

Merged
merged 4 commits into from
Aug 28, 2024
Merged

chore: Only check for test changes if there are also code changes #1806

merged 4 commits into from
Aug 28, 2024

Conversation

lindnerby
Copy link
Member

Description

Changes proposed in this pull request:

  • The check-tests should only report missing changes in _test.go files if there are also changes in *.go files present
  • If there are no changes in business code, then no changes in tests are needed

Related issue(s)

@lindnerby lindnerby requested a review from a team as a code owner August 28, 2024 07:28
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2024
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 28, 2024
@kyma-bot kyma-bot merged commit 578f780 into kyma-project:main Aug 28, 2024
38 checks passed
@lindnerby lindnerby deleted the only-check-tests-if-code-changes branch August 28, 2024 13:09
@lindnerby lindnerby assigned lindnerby and nesmabadr and unassigned nesmabadr Aug 28, 2024
@amritanshusikdar amritanshusikdar mentioned this pull request Sep 9, 2024
Open
2 tasks
@lindnerby lindnerby removed their assignment Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesmabadr nesmabadr nesmabadr approved these changes

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lindnerby @nesmabadr @kyma-bot