fix complex join example

kysely-org · Mar 22, 2024 · 9f836c4 · 9f836c4
1 parent e951eae
commit 9f836c4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/site/docs/examples/JOIN/0030-complex-join.js b/site/docs/examples/JOIN/0030-complex-join.js
@@ -4,7 +4,10 @@ export const complexJoin = `await db.selectFrom('person')
     (join) => join
       .onRef('pet.owner_id', '=', 'person.id')
       .on('pet.name', '=', 'Doggo')
-      .on((eb) => eb.or([eb("person.age", ">", 18), eb("person.age", "<", 100)]))
+      .on((eb) => eb.or([
+        eb('person.age', '>', 18),
+        eb('person.age', '<', 100)
+      ]))
   )
   .selectAll()
   .execute()`
diff --git a/src/query-builder/select-query-builder.ts b/src/query-builder/select-query-builder.ts
@@ -597,7 +597,10 @@ export interface SelectQueryBuilder<DB, TB extends keyof DB, O>
    *     (join) => join
    *       .onRef('pet.owner_id', '=', 'person.id')
    *       .on('pet.name', '=', 'Doggo')
-   *       .on((eb) => eb.or([eb("person.age", ">", 18), eb("person.age", "<", 100)]))
+   *       .on((eb) => eb.or([
+   *         eb('person.age', '>', 18),
+   *         eb('person.age', '<', 100)
+   *       ]))
    *   )
    *   .selectAll()
    *   .execute()
@@ -611,6 +614,10 @@ export interface SelectQueryBuilder<DB, TB extends keyof DB, O>
    * inner join "pet"
    * on "pet"."owner_id" = "person"."id"
    * and "pet"."name" = $1
+   * and (
+   *   "person"."age" > $2 OR
+   *   "person"."age" < $3
+   * )
    * ```
    *
    * <!-- siteExample("join", "Subquery join", 40) -->
@@ -2108,7 +2115,7 @@ class SelectQueryBuilderImpl<DB, TB extends keyof DB, O>
       ),
     })
   }
-  
+
   top(
     expression: number | bigint,
     modifiers?: TopModifier,