Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(alter-table): support multiple column operations #238

Merged
merged 12 commits into from
Dec 10, 2022
Merged

feat(alter-table): support multiple column operations #238

merged 12 commits into from
Dec 10, 2022

Conversation

naorpeled
Copy link
Contributor

@naorpeled naorpeled commented Nov 25, 2022 •
edited
Loading

  • feat(alter-table-node)!: allow multiple alter ops - allow multiple column alterations at AlterTableNode
  • def-query-compiler: align /w AlterTableNode
  • operation-node-transformer align /w AlterTableNode
  • add alter column builder
  • remove usages of ColumnDefinitionBuilderInterface
  • allow multiple col alterations@alter-table-builder
  • rename schema alterTable prop
  • added alter-column-builder to index
  • added and fixed unit tests

co authored by @igalklebanov
closes #217

@igalklebanov igalklebanov added api Related to library's API breaking change Includes breaking changes enhancement New feature or request labels Nov 25, 2022
naorpeled and others added 9 commits November 26, 2022 00:14
@naorpeled @igalklebanov
feat(alter-table-node)!: allow multiple alter ops
6fe3adf 
- allow multiple column alterations at `AlterTableNode`

Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
@naorpeled @igalklebanov
def-query-compiler: align /w AlterTableNode
2f3c31a 
Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
@naorpeled @igalklebanov
operation-node-transformer align /w AlterTableNode
21a99fd 
Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
@naorpeled @igalklebanov
add alter column builder
df0730e 
Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
@naorpeled @igalklebanov
remove usages of ColumnDefinitionBuilderInterface
314fc06 
Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
@naorpeled @igalklebanov
allow multiple col alterations@alter-table-builder
bebfb9a 
Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
@naorpeled @igalklebanov
rename schema alterTable prop
f9c79e9 
Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
@naorpeled @igalklebanov
added alter-column-builder to index
4a18ed5 
Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
@naorpeled @igalklebanov
added and fixed unit tests
56ee78f 
Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
@naorpeled naorpeled force-pushed the feat/alter-table/support-multiple-add-column branch from ef0a9ba to 56ee78f Compare November 25, 2022 22:16
@koskimas
Copy link
Member

koskimas commented Nov 28, 2022 •
edited
Loading

This looks really good! Sorry it's taking me a long time again. I'll try to review this thoroughly this week.

@koskimas koskimas merged commit 458b3c0 into kysely-org:master Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koskimas koskimas Awaiting requested review from koskimas

Assignees
No one assigned
Labels
api Related to library's API breaking change Includes breaking changes enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multiple column ALTER TABLE.
3 participants
@naorpeled @koskimas @igalklebanov