add using clause support @ DeleteQueryBuilder.
#241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalklebanov
added
api
igalklebanov
force-pushed
the
delete-from-using
branch
from
a485f95
to
c8d2f76
Compare
igalklebanov
changed the title
using(...) @ DeleteQueryBuilder.using clause support @ DeleteQueryBuilder.
naorpeled
reviewed
Dec 11, 2022
naorpeled
reviewed
Dec 11, 2022
naorpeled
approved these changes
Dec 11, 2022
Co-authored-by: Naor Peled <me@naor.dev>
koskimas
reviewed
Dec 28, 2022
|
Reverted all the renames and type bloat in |
|
Awesome! 💯 |
This was referenced Jan 1, 2023
|
Hi, thanks a lot for this functionality! I was just using it and did notice however that table names provided in the "using" clause are not picked up by the CamelCasePlugin, leading to an error. Using snake case in the using clause does work, but ends up causing type errors since the table name is not recognized. |
|
I created a PR to address the issue: feedback is appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
usingtoDeleteQueryBuilder:allows
mysqlconsumers to use additional tables to filter what gets deleted from TDF* (it also allows using joins now, as they were not usable previously). Caveat in spec is you have to repeat yourself and add TDF* again inusingclause in order to have additional tables (not in TDF*) as part of the query (viausingor in joins) -delete from t1 using t1, t2ordelete from t1 using t1 inner join t2.allows
postgresconsumers to use additional tables to filter what gets deleted from TDF*.* TDF = Table/s deleted from.
closes #177.
Takeaways:
A follow-up PR needs to address
DeleteQueryBuilder.returningAll(...). It should now allow passing a table argument (just likeSelectQueryBuilder.selectAll(...)) so we could havet2.*.A follow-up PR should add
QueryCreator.deleteFrom([t0, t1])support.mysqlsupports deleting from multiple tables, and current PR is a real tease to our consumers since it allows to filter by additional tables but still delete only from one.