Add UpdateResult.numChangedRows #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wirekang
changed the title
koskimas
requested changes
Apr 20, 2023
koskimas
requested changes
Apr 20, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
igalklebanov
added
enhancement
wirekang
commented
Jun 13, 2023
wirekang
commented
Jun 13, 2023
igalklebanov
approved these changes
Jul 3, 2023
There was a problem hiding this comment.
Went over @koskimas' comments, and changes made in response. Looks good to go on my end.
koskimas
approved these changes
Jul 5, 2023
Gaspero
pushed a commit
to Gaspero/kysely
that referenced
this pull request
Oct 2, 2023
* add numChangedRows * add tests for numChangedRows * reformat * refactor * fix typo * rename util function * update comments * rename Type to Constructor * make numChangedRows optional * fix test * update comments * remove Constructor type * fix type --------- Co-authored-by: Igal Klebanov <igalklebanov@gmail.com> Co-authored-by: Sami Koskimäki <koskomi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL-only feature,
changedRowsis returned from node-mysql2There are some non-related file changes because some files in master branch does not prettified well.
Closes #428