Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add stream() support for sqlite dialect #754

Merged
merged 5 commits into from
Nov 21, 2023
Merged

feat: add stream() support for sqlite dialect #754

merged 5 commits into from
Nov 21, 2023

Conversation

tgriesser
Copy link
Contributor

@vercel Vercel
Copy link

vercel bot commented Nov 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 10:16am

igalklebanov
igalklebanov reviewed Nov 1, 2023
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋

Thank you! 💪

Left some comments..

src/dialect/sqlite/sqlite-driver.ts Outdated Show resolved Hide resolved
src/dialect/sqlite/sqlite-driver.ts Show resolved Hide resolved
src/dialect/sqlite/sqlite-driver.ts Outdated Show resolved Hide resolved
@igalklebanov igalklebanov added enhancement New feature or request sqlite Related to sqlite built-in dialect Related to a built-in dialect ready for review labels Nov 3, 2023
tgriesser and others added 4 commits November 5, 2023 08:09
@tgriesser
feat: add stream() support for sqlite dialect
c1955d0
@tgriesser @igalklebanov
query.kind -> SelectQueryNode.is(query)
9fb354c 
Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
@tgriesser @igalklebanov
Reword error message
e7fef29 
Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>
@tgriesser
fix missing import
2fcde1f
koskimas
koskimas approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@koskimas koskimas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@koskimas koskimas merged commit 3d5e0e5 into kysely-org:master Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koskimas koskimas koskimas approved these changes

@igalklebanov igalklebanov Awaiting requested review from igalklebanov

Assignees
No one assigned
Labels
built-in dialect Related to a built-in dialect enhancement New feature or request sqlite Related to sqlite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgriesser @koskimas @igalklebanov