Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use esbuild without Vite #109

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Use esbuild without Vite #109

merged 6 commits into from
Feb 5, 2024

Conversation

kytta
Copy link
Owner

@kytta kytta commented Feb 5, 2024

Instead of battling with Vite (e.g. vitejs/vite#4863) and its configs, I have decided to drop it and to use esbuild directly. Builds are now 6x faster if running the script directly (not via PNPM). This has other advantages:

@kytta kytta self-assigned this Feb 5, 2024
Copy link
Contributor

github-actions bot commented Feb 5, 2024

size-limit report 📦

Path Size
./dist/shareon.min.css 5.97 KB (+0.05% 🔺)
./dist/shareon.es.js 0 B (-100% 🔽)
./dist/shareon.mjs 984 B (+100% 🔺)

@kytta kytta changed the base branch from main to next February 5, 2024 20:57
@kytta kytta marked this pull request as ready for review February 5, 2024 21:13
@kytta kytta merged commit ded589c into next Feb 5, 2024
1 check passed
@kytta kytta deleted the esbuild branch February 5, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant