Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NIM #146

Merged
merged 6 commits into from
Aug 16, 2019
Merged

Support NIM #146

merged 6 commits into from
Aug 16, 2019

Conversation

chaemon
Copy link
Contributor

@chaemon chaemon commented Aug 4, 2019

NIM言語を追加しました。

code生成とsubmitに対応しています。

@kyuridenamida
Copy link
Owner

いい感じです!テストを追加してもらえますか?
#145 でちょうどテストに関する議論が進行しています

@codecov-io
Copy link

codecov-io commented Aug 11, 2019

Codecov Report

Merging #146 into master will increase coverage by 0.31%.
The diff coverage is 94.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
+ Coverage   88.92%   89.24%   +0.31%     
==========================================
  Files          49       51       +2     
  Lines        2231     2353     +122     
==========================================
+ Hits         1984     2100     +116     
- Misses        247      253       +6
Impacted Files Coverage Δ
atcodertools/common/language.py 96.66% <100%> (+0.11%) ⬆️
atcodertools/codegen/code_generators/nim.py 94.33% <94.33%> (ø)
atcodertools/tools/envgen.py 81.48% <0%> (-0.23%) ⬇️
atcodertools/tools/tester.py 87.07% <0%> (ø) ⬆️
...codertools/constprediction/constants_prediction.py 92.3% <0%> (ø) ⬆️
atcodertools/client/atcoder.py 90.37% <0%> (ø) ⬆️
atcodertools/tools/submit.py 60.37% <0%> (ø) ⬆️
atcodertools/tools/codegen.py 77.08% <0%> (ø) ⬆️
atcodertools/common/logging.py 100% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d9e7a4...6bbed5e. Read the comment docs.

tests/test_codegen.py Outdated Show resolved Hide resolved
tests/test_codegen.py Outdated Show resolved Hide resolved
tests/test_codegen.py Show resolved Hide resolved
@kyuridenamida
Copy link
Owner

@chaemon 変更後のresolve後にpush忘れてたりしませんか?

Copy link
Owner

@kyuridenamida kyuridenamida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです!

@chaemon
Copy link
Contributor Author

chaemon commented Aug 16, 2019

ありがとうございます!

@kyuridenamida kyuridenamida changed the title NIM言語を追加しました。 NIM言語を追加 Aug 16, 2019
@kyuridenamida kyuridenamida merged commit 163237c into kyuridenamida:master Aug 16, 2019
penpenpng added a commit to penpenpng/atcoder-tools that referenced this pull request Aug 17, 2019
@kyuridenamida kyuridenamida added this to the 1.1.5 milestone Aug 19, 2019
@kyuridenamida kyuridenamida changed the title NIM言語を追加 Support NIM Aug 19, 2019
@chaemon
Copy link
Contributor Author

chaemon commented Oct 13, 2019

interactive_test.zip

@chaemon
Copy link
Contributor Author

chaemon commented Oct 13, 2019

動作確認用のファイルを追加してみました。
使い方は以下です。

  1. PRのatcoder-toolsを用いて、生成。言語はcppとしておく。
    $ atcoder-tools gen practice
  2. interactive_test.zipを解凍してpracticeフォルダの内容を上書きする。
  3. main.cpp, judge.cppをそれぞれコンパイルして実行ファイル名をmain, judgeとする
    $ g++ -omain main.cpp
    $ g++ -ojudge judge.cpp
  4. testを実行
    $ atcoder-tools test
    (もしかしたら1. は不要?)

Acceptedとなったら成功です。もう一問dwacon2018-prelimsも用意しましたので、試してみてください。また、ACだと何もでなくてつまらないので、適当にWAやTLEにしてみて挙動をみてください。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants