Fix a bug flake8 in .travis.yml doesn't work #150
Merged
+1
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flake8 --ignore=E501, W605
はW605
という空の module に対して検査をかけてしまうため、常に成功します。これはまずいので修正します。その他の注意:
./webapp/node_modules/node-gyp/gyp/tools/pretty_vcproj.py
などもひっかかるためです--exclude
は指定しないとatcodertools/tools/templates/default_template.py
やtests/resources/test_codegen/template_jinja.py
などまでひっかかってしまいますW503
はline break before binary operator
であり、 formatter との衝突を回避するため--ignore
します