Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug flake8 in .travis.yml doesn't work #150

Merged
merged 2 commits into from
Aug 19, 2019

Conversation

kmyk
Copy link
Contributor

@kmyk kmyk commented Aug 18, 2019

flake8 --ignore=E501, W605W605 という空の module に対して検査をかけてしまうため、常に成功します。これはまずいので修正します。

その他の注意:

  • ディレクトリの指定があるのは、省略すると ./webapp/node_modules/node-gyp/gyp/tools/pretty_vcproj.py などもひっかかるためです
  • --exclude は指定しないと atcodertools/tools/templates/default_template.pytests/resources/test_codegen/template_jinja.py などまでひっかかってしまいます
  • W503line break before binary operator であり、 formatter との衝突を回避するため --ignore します
  • flake8 に違反するコードがいくつかあったのでついでに修正しました

@codecov-io
Copy link

codecov-io commented Aug 18, 2019

Codecov Report

Merging #150 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   89.58%   89.57%   -0.01%     
==========================================
  Files          52       52              
  Lines        2467     2466       -1     
==========================================
- Hits         2210     2209       -1     
  Misses        257      257
Impacted Files Coverage Δ
atcodertools/tools/codegen.py 77.31% <ø> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4305c...5d354f2. Read the comment docs.

@kyuridenamida
Copy link
Owner

ワロタ ありがとうございます

@kyuridenamida kyuridenamida merged commit 2acb5ed into kyuridenamida:master Aug 19, 2019
@kyuridenamida kyuridenamida added this to the 1.1.5 milestone Aug 19, 2019
@kyuridenamida kyuridenamida changed the title .travis.yml に書かれている flake8 が実は動いてなかったので有効にする Fix a bug flake8 in .travis.yml doesn't work Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants