Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support C# #153

Merged
merged 17 commits into from
Sep 1, 2019
Merged

Support C# #153

merged 17 commits into from
Sep 1, 2019

Conversation

chaemon
Copy link
Contributor

@chaemon chaemon commented Aug 19, 2019

Languageクラスでdefault code styleを指定できるようにしました。indent_type, indent_widthを指定できます。

default code styleの指定がある場合はこちらを優先、ない場合はデフォルト引数が指定されるようにしました。

.atcodertools.tomlの設定はこの両者よりもさらに優先されます。

@kyuridenamida
Copy link
Owner

無理矢理別の方向性で修正したため衝突事故が起きてしまった...すみません

@codecov-io
Copy link

codecov-io commented Aug 20, 2019

Codecov Report

Merging #153 into master will increase coverage by 0.24%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   89.61%   89.85%   +0.24%     
==========================================
  Files          52       53       +1     
  Lines        2474     2582     +108     
==========================================
+ Hits         2217     2320     +103     
- Misses        257      262       +5
Impacted Files Coverage Δ
atcodertools/common/language.py 97.22% <100%> (+0.07%) ⬆️
atcodertools/codegen/code_generators/cs.py 95.32% <95.32%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 302d80b...e7c4c64. Read the comment docs.

@chaemon chaemon changed the title default code styleを変更 C#のcode generatorを追加 Aug 25, 2019
atcodertools/common/language.py Outdated Show resolved Hide resolved
Copy link
Owner

@kyuridenamida kyuridenamida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません間違えてapproveしてしまいました。変更できますか。

@chaemon
Copy link
Contributor Author

chaemon commented Aug 26, 2019

すみません。NIMのを一部そのままコピーしちゃったところがあったようです。。。直します。

@kyuridenamida
Copy link
Owner

kyuridenamida commented Aug 26, 2019

衝突してるみたいです。最新のmasterを一度手元でマージしてもらえますか?

@kyuridenamida kyuridenamida changed the title C#のcode generatorを追加 Support C# Aug 26, 2019
@kyuridenamida
Copy link
Owner

ありがとうございます。マージします

@kyuridenamida kyuridenamida merged commit 1126750 into kyuridenamida:master Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants