Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use input_part_prefix to generate code properly #242

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

kotet
Copy link
Contributor

@kotet kotet commented Aug 14, 2021

Why is this change needed?

Fix #241
入力形式の推論に失敗したときもScanner等を初期化するコードが生成されているため、input_part_prefixを使って初期化コードをinput_partに含める必要がある。

What did you implement?

コメントアウトされていたinput_part_prefixをアンコメント。
それに伴ってテンプレートにハードコーディングされていた初期化コードを削除

What behavior do you expect?

テンプレートから初期化コードを削除したが、テストで出力されるコードが変化しない。

@kyuridenamida
Copy link
Owner

ありがとうございます!

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2021

Codecov Report

Merging #242 (77e8e1c) into stable (8ff1461) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable     #242      +/-   ##
==========================================
+ Coverage   89.27%   89.46%   +0.19%     
==========================================
  Files          61       61              
  Lines        2582     2582              
==========================================
+ Hits         2305     2310       +5     
+ Misses        277      272       -5     
Impacted Files Coverage Δ
...odegen/code_generators/universal_code_generator.py 98.13% <0.00%> (+2.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ff1461...77e8e1c. Read the comment docs.

@kyuridenamida
Copy link
Owner

よさそうです!

@kyuridenamida kyuridenamida merged commit 949428c into kyuridenamida:stable Aug 19, 2021
@kyuridenamida
Copy link
Owner

2.8.0としてリリースしますね

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input_part_prefixが使われていない
3 participants