Removal of redundant values #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for your contribution. You're right, I missed this in the cleanup. Can you also please recommit with the git reset --soft HEAD~1
git add .
git commit -m "..." -s
git push origin main -f |
fjogeleit
reviewed
Jan 19, 2022
Signed-off-by: Anders Bennedsgaard <abbennedsgaard@gmail.com>
Signed-off-by: Anders Bennedsgaard <abbennedsgaard@gmail.com>
Signed-off-by: Anders Bennedsgaard <abbennedsgaard@gmail.com>
Signed-off-by: Anders Bennedsgaard <abbennedsgaard@gmail.com>
|
Sorry, I'm not very used to working on OSS, but hopefully it works now 😄 |
|
Yes, looks good. If the linting fails because of the unchanged version, that’s no problem. I will prepare it today. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
values.yaml,monitoring.namespace: cattle-dashboardsleads the developer to think that this namespace is where Grafana should be located on the cluster. However fromcharts/policy-reporter/charts/monitoring/templates/_helpers.tpl, it should actually bemonitoring.grafana.namespace.This PR gives a description that
monitoring.namespaceshould not be used and only remains due to backwards compatability (#92), and removesmonitoring.serviceMonitordefaults which should be left to the monitoring subchart.