Make grafana dashboard label value configurable #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Stone <zach@giantswarm.io>
Signed-off-by: Zach Stone <zach@giantswarm.io>
stone-z
force-pushed
the
configure-grafana-label-value
branch
from
bc65b15
to
6c51856
Compare
Pull Request Test Coverage Report for Build 2516299851
💛 - Coveralls |
Signed-off-by: Zach Stone <zach@giantswarm.io>
Signed-off-by: Zach Stone <zach@giantswarm.io>
fjogeleit
approved these changes
Jun 17, 2022
|
Thanks for your contribution, I will create a release in the upcoming days. |
|
Your change is released as HelmChart v2.9.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default label for grafana to detect and load a dashboard from a ConfigMap is
grafana_dashboard: "1". The monitoring chart already allows specifying a different label, but not a different value. This PR makes the value configurable as well, in case other users would also like to use different values than the default "1".