Make image registries configurable #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Stone <zach@giantswarm.io>
stone-z
force-pushed
the
configure-registry
branch
from
15aed30
to
304e163
Compare
|
Hey, thank you for your feedback and this contribution. I will try it out and make a new release if everyhting is working. So ignore the failing chart linting check because of the missing version update. |
Pull Request Test Coverage Report for Build 1242828649
💛 - Coveralls |
|
@stone-z your change is released with 1.9.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋 first of all, thanks for maintaining this project! It's a really nice addition
We'd like to be able to template in alternative registries for running in environments where pulling from Docker Hub isn't an option. So, this PR adds that