Add #[ignore] attribute to ignore test arguments #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
la10736
reviewed
Jul 21, 2024
rstest_macros/src/parse/ignore.rs
Outdated
Comment on lines
52
to
61
| #[rstest] | ||
| #[case::no_more_than_one("fn f(#[ignore] #[ignore] a: u32) {}", "more than once")] | ||
| fn raise_error(#[case] item_fn: &str, #[case] message: &str) { | ||
| let mut item_fn: ItemFn = item_fn.ast(); | ||
|
|
||
| let err = extract_ignores(&mut item_fn).unwrap_err(); | ||
|
|
||
| assert_in!(format!("{:?}", err), message); | ||
| } | ||
| } |
There was a problem hiding this comment.
Use rstest here is a little bit overkill ... but is fine 😄
There was a problem hiding this comment.
I copied it from the by_ref implementation...converted to a simple test 👍
la10736
reviewed
Jul 21, 2024
Comment on lines
1184
to
+1187
| /// | ||
| /// ## Ignoring Arguments | ||
| /// | ||
| /// Sometimes, you may want to inject and use fixtures not managed by rstest |
There was a problem hiding this comment.
Just a note: please can you add a little note in Inject Test Attribute with a link to this section?
la10736
requested changes
Jul 21, 2024
There was a problem hiding this comment.
That's a greate job. I just ask you to add a little note in the test inject attribute section to recall this feature.... I guess that allmost of the peaple will find it usefull.
If you don't have time nevermid about this... Let me know and I'll do it by myself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
#[ignore]attribute to allow to ignore test arguments and let other crates (e.g. sqlx test runner or other proc macros) take care of them.Fixes #228 and #91
Developed during