Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to async-std v1.13 #274

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Sep 7, 2024

No description provided.

@la10736
Copy link
Owner

la10736 commented Sep 9, 2024

Thanks!!!
Anyway, can you explain why you need to bump the asyc-std version?

@jayvdb
Copy link
Contributor Author

jayvdb commented Sep 9, 2024

async-std 0.12 is 2 years old, and has some very old dependencies.

@la10736 la10736 merged commit 5b0164f into la10736:master Sep 16, 2024
2 checks passed
@jayvdb jayvdb deleted the update-async-std branch September 16, 2024 08:23
@EdJoPaTo
Copy link

EdJoPaTo commented Oct 1, 2024

Saw the release notes and am curious: Why is this relevant? I would expect this to be done automatically by Cargo. Without a lock file the current one will be used and as it's a dev-dependency it's not relevant for the users of rstest as a library. (With the upcoming edition 2024 / resolver 3 it will use the latest one compatible with your current Rust version so its even more helpful to keep the actual required minimal version.)
Am I overlooking something?

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 1, 2024

I guess you saw it on https://github.com/la10736/rstest/releases/tag/v0.23.0 , which is automated and exhaustive.

Not on https://github.com/la10736/rstest/blob/master/CHANGELOG.md , which is manually curated.

This PR doesnt impact users much, which is why it would be omitted from CHANGELOG.md.

This PR did change the lib docs, so rstest users who copy&paste from the readme/docs would get a modern async-std. Telling users to depend on async-std v1.5 was really old advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants