Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional improvements Application and Physics Engine, Bugfixes #164

Open
wants to merge 231 commits into
base: v1beta
Choose a base branch
from
Open

Functional improvements Application and Physics Engine, Bugfixes #164

wants to merge 231 commits into from

Conversation

JaapvanEkris
Copy link
Contributor

@JaapvanEkris JaapvanEkris commented Mar 11, 2024 •
edited
Loading

New functionality:

  • Added support for ANT+ rowing metrics broadcast
  • Allow the user to change the GUI layout and metrics, including displaying the force curve
  • Allow user to turn on or off ANT+ and BLE functionality and dynamically switch between ANT+ and BLE HR monitors from the GUI
  • Added support for creating Garmin Fit-files, including reporting of distance per stroke, workout plan, intervals, splits and pauses. Files work with Garmin, Strava and intervals.icu
  • tcx-files and RowsAndAll files now have support for splits, intervals and pauses as well
  • Added the option for more complex workouts, as a hook for the PM5 and webinterface (these are a ToDo where the PM5 workout interface and GUI is still in development, but they can be set in server.js already)
  • Added PM5 Interval-types, including splits, in the datastructure

Added some bugfixes/robustness/accuracy improvements:

  • Added support for the newest version of Raspberry Pi OS (Bookworm), moved from Node.js v16 (EOL) to Node.js v20 (current) and upgraded packages where possible. Is known to work on Raspberry Pi 3 and 4
  • Drastic improvement of the architecture to make it more robust and more extensible
  • Improved the Session manager to drastically improve session limit measurement, especially with less data intensive machines
  • Improved the accuracy, responsiveness and efficiency of both the Linear and Quadratic the Theil-Sen algorithms. For larger 'flankLength' machines (12+ datapoints), this improved algorithm will also result in 50% reduction in CPU use, while increasing the responsiveness and accuracy of the forcecurve and powercurve. For smaller 'flankLength' machines it will improve less, but still improve.
  • All linear calculations (stroke detection, Drag calculation, recovery slope calculation) now use the Linear Theil-Sen algorithm, making this calculation more robust against outliers and stroke detection errors
  • Added a configuration sanity check which logs obvious errors and (if possible) repairs settings, after several users messed up their config and got completely stuck.
  • The configuration sanity check also provides an automated upgrade path for 0.8.4 users to V1Beta, as all the newly added configuration items between these two versions are automatically detected, logged and repaired.
  • Added restart limits to prevent infinite boot loops of the app crashing and rebooting when there is a config error
  • Fixed the GPIO tick rollover, which led to a minor hickup in data in rows over 30 minutes
  • Made Flywheel.js more robust against faulty GPIO data
  • Fixed an application crash in the RowingData generation when the target directory doesn't exist yet
  • Improved the structure of the peripherals to allow a more robust BLE and ANT use

@JaapvanEkris
Fixed a bug in tick rollover
51400f2 
Fixed a bug in the tick rollover (which seems to happen every 60 minutes of processtime).
@JaapvanEkris
Several bugfixes and improvements
6623aa2 
Bugfix: Fixed a bug where a new year or month would crash the workoutrecorder due to a missing data directory

Several improvements:
* Added possibility of only creating RowingData file
* Improved HRR data when restarting a workout
@JaapvanEkris
A bit more defensive programming
062faa0 
A bit more defensive programming as one bad (NaN) measurement of CurrentDt will kill all metrics for the entire session.
@JaapvanEkris
Fixed a typo in function name
35ff348 
To add insult to injury: by a typo in the error logging function, the app would crash if there was a recoverable error
@JaapvanEkris
Expansion of the Interval type
733720f 
Addittion of the interval type, as a preperation of the more complex workout schedules
@JaapvanEkris
Improvement of code quality
b4e8f16 
Replaced the horrible ested If...then....else with a much more readable case statement to implement the Concept 2 table
@JaapvanEkris
Fixed a missing bracket
11ff22e
@JaapvanEkris
Added sanity checks to the config manager
e29d723 
Added a lot of sanity checks to the loading of the config.
@JaapvanEkris
Improvement of code quality
dc43c38 
Improvement of code quality
@JaapvanEkris
Fixed Lint errors
0378f27 
Fixed Lint errors
@JaapvanEkris
Centralising parameter check
ce9294d 
Removed sanity checks in RowingStatistics, as the configmanager centralises the parameter check
@JaapvanEkris
Centralising parameter check
3364ef3 
Removed sanity checks in RowingStatistics, as the configmanager centralises the parameter check
@JaapvanEkris
Allowed the config check to repair settings
fb64547 
Added the ability to automatically fix forgotten or implausible settings when possible.
@JaapvanEkris
Removed some artificial limits
fcb3944
@JaapvanEkris
Added logic for more complex workouts
94a2aad 
Added logic for more complex workouts: RowingStatistics will handle this completely independently
@JaapvanEkris
Update to facilitate more complex workouts
37edd02 
Update to facilitate more complex workouts. RowingStatistics will now manage the intervals completely independently and alert server.js only when the session has ended.
@JaapvanEkris
Removal of surplus logging line
1405b80
@JaapvanEkris
Fixed a Lint error
e569637
@JaapvanEkris
Added Intervals.icu compatibility
758f2d2 
Added Intervals.icu to the list of compatible users of tcx files.
@JaapvanEkris
Updates to fix review comments
f628a6e 
Updates to fix review comments
@JaapvanEkris
Added workout management to RowingStatistics
75e2455 
Added workout management to the role of RowingStatistics
@JaapvanEkris
Fixed Line error
d67745c 
Fixed Line error
@JaapvanEkris
Douncheck with 0.8.4 settings
7251a81 
Checked that the sanity check would fix all mew variables, allowing a 0.8.4 config file to be used with V1Beta without any crashes or issues.
@JaapvanEkris
Added restart limit to prevent bootloop
f1e7d08 
Added a restart limit to the service definition to prevent an infinite bootloop
@JaapvanEkris
Added restart limit to prevent bootloop
675c85c 
Added a restart limit to the service definition to prevent an infinite bootloop
@JaapvanEkris
Move functionality to the Finite State Machine
3695331 
On hindsight, the approach of letting the FSM handle all state transitions explicitly is much clearer
@JaapvanEkris
Move functionality to the Finite State Machine
6eed136 
On hindsight, the approach of letting the FSM handle all state transitions explicitly is much clearer
@JaapvanEkris
Added paragraph about handle-based sensors
3e2f954 
Added a paragraph about handle-based sensors.
@JaapvanEkris
Added reason to modify hardware setup
f7aae7b 
Added reason to modify hardware setup in documentation
@JaapvanEkris
Added link to software setup
b473953 
Added link to software setup
JaapvanEkris and others added 30 commits January 10, 2024 15:45
@JaapvanEkris
Update to allow installation on Debian 12 'Bookworm'
b747b61
@JaapvanEkris
Fixed a bug in the install script
265a459 
Fixed a bug reported by pirower. Many thanks for reporting!
@JaapvanEkris
Improvement of the dragfactor calculation by using Linear Theil-Sen e…
2934fef 
…stimator (#27)

* Explanation of the improvement

* Addition of the defaultValue property

* Change to use Lin. TS for Drag calculation

Changing the drag and recovery slope calculation from OLS to Linear Theil-Sen

* Fixed Lint error

* Improvement of the RowErg profile

Adaptation of the Concept2 RowErg profile to the new algorithms

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Update Rower.test.js

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm

* Adaptation to improved drag calculation algorithm
@JaapvanEkris
Update of the essential npm dependencies (#30)
a434744 
* Update install.sh

* Update package.json

* Update package-lock.json

* Update package.json

* Update package-lock.json

* Update package.json

* Update package-lock.json

* Update install.sh

* Update README.md

* Update installation.md

* Update README.md

* Create Release_Notes.md

* Update Release_Notes.md

* Update Release_Notes.md

* Update Release_Notes.md

* Update README.md

* Update backlog.md

* Update Release_Notes.md

* Update Release_Notes.md

* Update Release_Notes.md

* Update Release_Notes.md

* Update Release_Notes.md

* Update rower_settings.md

* Update physics_openrowingmonitor.md

* Fixed Lint errors

* Update installation.md

* Fix Lint errors
@JaapvanEkris
Added error message on Bookworm
91ad5b7 
Added an error message on the Bookworm install, as the Window manager is totally different.
@JaapvanEkris
Update of several non-essential packages (#31)
4066ea5 
* Update package.json

* Update package-lock.json
@JaapvanEkris
Upgrade to Node.js V18 (#32)
854a880 
* Update install.sh

* Create .npmrc

* Update install.sh

* Update server.js

* Update config.js

* Update RowingStatistics.js
@JaapvanEkris
Update node.js.yml
8d492ec
@JaapvanEkris
Added a Raspberry Pi Zero W depreciation warning (#34)
f1d38aa 
Added an active depreciation warning to the Pi Zero W installs (see #33)
@JaapvanEkris
Set redirect to Pi Zero branch
da28104
@JaapvanEkris
Update to support Raspberry Pi Bookworm and Node.js V20 (#36)
cf80aa7 
* Switch to Node.js V20

* Failsafe for updating using the wrong branch

* Update to Node.js v20 and support for RPi OS Bookworm

* Update to Node.js V20

* Update to Node.js V20

* Update install.sh

* Update install.sh

* Update install.sh

* Update install.sh

* Update package.json

* Update package-lock.json
@JaapvanEkris
Update Release_Notes.md
60ecfeb
@JaapvanEkris
Removal of Raspberry Pi Zero support
7ae029d
@JaapvanEkris
Dropped support for the Raspberry Pi Zero
f1b621f
@JaapvanEkris
Fix of an array processing error in the Theil-Sen regressor (#40)
414372e 
Update to fix an error in both Theil-Sen regressors, as the arrays used were not processed completely. Thanks to @Abasz for reporting.
@JaapvanEkris
Update physics_openrowingmonitor.md
2d647d1
@JaapvanEkris
Bugfix in config error message
f628f30
@JaapvanEkris
Update branch name
8d9cb15
@JaapvanEkris
Change in Branch name
1c02f74
@JaapvanEkris
Newly supported rowers
6bc2931
@JaapvanEkris
Updated supported rowers list
59ccca0
@JaapvanEkris
Added support status for the JLL Ventus 2
f4d12ec
@ak6i
Improvement of the installation script, to allow easier restarts when…
dacae41 
… the install fails
@JaapvanEkris
Update Supported_Rowers.md
7d71a04
@JaapvanEkris
Added Concept2 Model C
1080dfe
@JaapvanEkris
Added support for the Jorot MR380
83ef012
@JaapvanEkris
Improvement of the TS regression algorithm and stroke detection (#51)
8d374a4 
Change the startup and powerdown behaviour to depend on Angular velocity, as that is constructed using the TS-calculation, reducing the dependency on an individual measurement.

Inserted more explicit memory management by setting values to null before destroying the node, in order to make the Garbage collector's work a bit easier. This fixes a lot of memory leaks.

Performance improvement of the Quadratic TS Series: Implementation of a lazy algorithm to calculate B, C and goodnessOfFit, avoiding the unneccessary calculation of them when not needed/used.

Improved coding style: Instead of making explicit function calls, we now expose the underlying series, allowing use of their functions directly.

Adds different rowers, including the model C (see laberning#157 )
@JaapvanEkris
Update install.sh
2b2c0d4
@JaapvanEkris
Removed the Pi5 from the compatibility list
25c06e8
@JaapvanEkris
Update README.md
d405fb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JaapvanEkris @Abasz @Gordon-Shumway2 @ak6i