attrs fixes and update #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #116 +/- ##
======================================
Coverage 50.7% 50.7%
======================================
Files 81 81
Lines 3954 3954
======================================
Hits 2005 2005
Misses 1949 1949
Continue to review full report at Codecov.
|
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
We mostly don't need the compare functionality of attrs. Disable it to fall back to object id hashes (similar to python standard classes). The only exception is the ResourceMatch class, since we collect these into a list and need to remove them later on. The list remove function requires the implementation of the compare functions, explicitly enable it for the ResourceMatch class. Fixes #106 Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
We still require attrs>=16.3.0 for the post init functionality. Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
We were stuck on attrs==16.3.0 since 17.1.0 introduced breaking changes to the attr.s compare behaviour. Due to dependency problems, we could not use crossbar>17.3.1. We resolved the attrs dependencies in the previous commits and can unpin specific versions from our dependency list. Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Emantor
force-pushed
the
topic/attrs-update
branch
from
d095e66
to
789df82
Compare
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
Emantor
force-pushed
the
topic/attrs-update
branch
from
789df82
to
aa2c1d8
Compare
jluebbe
approved these changes
Aug 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.