pyproject.yaml: limit pysnmp to versions < 6 #1332

Emantor · 2024-02-23T14:27:13Z

Description
The new major release 6.0 introduces breaking changes (functions are now async), limit the dependency until we fix this properly.

Checklist

PR has been tested

The new major release 6.0 introduces breaking changes (functions are now async), limit the dependency until we fix this properly. Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>

codecov · 2024-02-23T14:31:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.8%. Comparing base (64ed1cd) to head (b9e1c92).

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #1332     +/-   ##
========================================
- Coverage    62.8%   62.8%   -0.1%     
========================================
  Files         163     163             
  Lines       12019   12019             
========================================
- Hits         7550    7549      -1     
- Misses       4469    4470      +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pysnmp depends on pyasn1. `pyasn1.compat.octets` was removed in pyasn1 0.6.1 [1] leading to ModuleNotFoundErrors in labgrid's "eaton" and "poe_mib" power backends: _______________ TestNetworkPowerDriver.test_import_backend_eaton _______________ self = <test_powerdriver.TestNetworkPowerDriver object at 0x7f84794bfdd0> def test_import_backend_eaton(self): pytest.importorskip("pysnmp") > import labgrid.driver.power.eaton tests/test_powerdriver.py:295: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ labgrid/driver/power/eaton.py:2: in <module> from ...util.snmp import SimpleSNMP labgrid/util/snmp.py:1: in <module> from pysnmp import hlapi /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/hlapi/__init__.py:7: in <module> from pysnmp.proto.rfc1902 import * /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/proto/rfc1902.py:8: in <module> from pysnmp.proto import rfc1155, error /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/proto/rfc1155.py:10: in <module> from pysnmp.proto import error /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/proto/error.py:9: in <module> from pysnmp import debug _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ # # This file is part of pysnmp software. # # Copyright (c) 2005-2019, Ilya Etingof <etingof@gmail.com> # License: https://www.pysnmp.com/pysnmp/license.html # import logging > from pyasn1.compat.octets import octs2ints E ModuleNotFoundError: No module named 'pyasn1.compat.octets' /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/debug.py:8: ModuleNotFoundError ______________ TestNetworkPowerDriver.test_import_backend_poe_mib ______________ self = <test_powerdriver.TestNetworkPowerDriver object at 0x7f84794bd910> def test_import_backend_poe_mib(self): pytest.importorskip("pysnmp") > import labgrid.driver.power.poe_mib tests/test_powerdriver.py:307: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ labgrid/driver/power/poe_mib.py:4: in <module> from ...util.snmp import SimpleSNMP labgrid/util/snmp.py:1: in <module> from pysnmp import hlapi /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/hlapi/__init__.py:7: in <module> from pysnmp.proto.rfc1902 import * /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/proto/rfc1902.py:8: in <module> from pysnmp.proto import rfc1155, error /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/proto/rfc1155.py:10: in <module> from pysnmp.proto import error /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/proto/error.py:9: in <module> from pysnmp import debug _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ # # This file is part of pysnmp software. # # Copyright (c) 2005-2019, Ilya Etingof <etingof@gmail.com> # License: https://www.pysnmp.com/pysnmp/license.html # import logging > from pyasn1.compat.octets import octs2ints E ModuleNotFoundError: No module named 'pyasn1.compat.octets' /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/debug.py:8: ModuleNotFoundError The issue is documented upstream [2]. [3] limited the pysnmp version to <6. pysnmp 6.1.4, 6.2.6, and 7.1.0 are not affected. For stable, limit compatible pyasn1 versions to <0.6.1. On master, [5] switches labgrid to pysnmp's asyncio API, thereby dropping the upper bound introduced by [3]. [1] https://github.com/pyasn1/pyasn1/releases/tag/v0.6.1 [2] pyasn1/pyasn1#76 [3] labgrid-project#1332 [4] lextudio/pysnmp#113 (comment) [5] labgrid-project#1497 Signed-off-by: Bastian Krause <bst@pengutronix.de>

pysnmp depends on pyasn1. `pyasn1.compat.octets` was removed in pyasn1 0.6.1 [1] leading to ModuleNotFoundErrors in labgrid's "eaton" and "poe_mib" power backends: _______________ TestNetworkPowerDriver.test_import_backend_eaton _______________ self = <test_powerdriver.TestNetworkPowerDriver object at 0x7f84794bfdd0> def test_import_backend_eaton(self): pytest.importorskip("pysnmp") > import labgrid.driver.power.eaton tests/test_powerdriver.py:295: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ labgrid/driver/power/eaton.py:2: in <module> from ...util.snmp import SimpleSNMP labgrid/util/snmp.py:1: in <module> from pysnmp import hlapi /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/hlapi/__init__.py:7: in <module> from pysnmp.proto.rfc1902 import * /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/proto/rfc1902.py:8: in <module> from pysnmp.proto import rfc1155, error /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/proto/rfc1155.py:10: in <module> from pysnmp.proto import error /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/proto/error.py:9: in <module> from pysnmp import debug _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ # # This file is part of pysnmp software. # # Copyright (c) 2005-2019, Ilya Etingof <etingof@gmail.com> # License: https://www.pysnmp.com/pysnmp/license.html # import logging > from pyasn1.compat.octets import octs2ints E ModuleNotFoundError: No module named 'pyasn1.compat.octets' /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/debug.py:8: ModuleNotFoundError ______________ TestNetworkPowerDriver.test_import_backend_poe_mib ______________ self = <test_powerdriver.TestNetworkPowerDriver object at 0x7f84794bd910> def test_import_backend_poe_mib(self): pytest.importorskip("pysnmp") > import labgrid.driver.power.poe_mib tests/test_powerdriver.py:307: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ labgrid/driver/power/poe_mib.py:4: in <module> from ...util.snmp import SimpleSNMP labgrid/util/snmp.py:1: in <module> from pysnmp import hlapi /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/hlapi/__init__.py:7: in <module> from pysnmp.proto.rfc1902 import * /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/proto/rfc1902.py:8: in <module> from pysnmp.proto import rfc1155, error /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/proto/rfc1155.py:10: in <module> from pysnmp.proto import error /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/proto/error.py:9: in <module> from pysnmp import debug _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ # # This file is part of pysnmp software. # # Copyright (c) 2005-2019, Ilya Etingof <etingof@gmail.com> # License: https://www.pysnmp.com/pysnmp/license.html # import logging > from pyasn1.compat.octets import octs2ints E ModuleNotFoundError: No module named 'pyasn1.compat.octets' /opt/hostedtoolcache/Python/3.12.5/x64/lib/python3.12/site-packages/pysnmp/debug.py:8: ModuleNotFoundError The issue is documented upstream [2]. [3] limited the pysnmp version to <6. pysnmp 6.1.4, 6.2.6, and 7.1.0 are not affected. Limit compatible pyasn1 versions to <0.6.1 until [5] switches labgrid to pysnmp's asyncio API, thereby dropping the upper bound introduced by [3]. While at it, switch from "pysnmp-lextudio" to "pysnmp". The original author of pysnmp passed away and the lextudio folks took over maintenanc. While the request to take over the pysnmp PyPi project was pending, the maintained fork was called pysnmp-lextudio (see labgrid-project#1186, aa2549c). Now that the migration is complete, let's move back to the original package name. See: [6] [1] https://github.com/pyasn1/pyasn1/releases/tag/v0.6.1 [2] pyasn1/pyasn1#76 [3] labgrid-project#1332 [4] lextudio/pysnmp#113 (comment) [5] labgrid-project#1497 [6] etingof/pysnmp#429 Signed-off-by: Bastian Krause <bst@pengutronix.de>

pyproject.yaml: limit pysnmp to versions < 6

b9e1c92

The new major release 6.0 introduces breaking changes (functions are now async), limit the dependency until we fix this properly. Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>

Emantor requested a review from Bastian-Krause February 23, 2024 14:27

Bastian-Krause approved these changes Feb 23, 2024

View reviewed changes

Emantor merged commit f432076 into labgrid-project:master Feb 23, 2024
10 of 11 checks passed

Emantor deleted the topic/limit-pysnmp branch February 23, 2024 15:41

Bastian-Krause mentioned this pull request Sep 11, 2024

pyasn1 0.6.1 breaks eaton and poe_mib power backends #1493

Open

Bastian-Krause mentioned this pull request Oct 10, 2024

pyproject.toml: limit pysnmp's pyasn1 dependency to <0.6.0 #1522

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pyproject.yaml: limit pysnmp to versions < 6 #1332

pyproject.yaml: limit pysnmp to versions < 6 #1332

Emantor commented Feb 23, 2024

codecov bot commented Feb 23, 2024 •

edited

Loading

pyproject.yaml: limit pysnmp to versions < 6 #1332

pyproject.yaml: limit pysnmp to versions < 6 #1332

Conversation

Emantor commented Feb 23, 2024

codecov bot commented Feb 23, 2024 • edited Loading

Codecov Report

codecov bot commented Feb 23, 2024 •

edited

Loading