ci,test: Pass the build root path explicitly when running tests #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This fixes plugin discvoery failures after #1317.
achimnol
added
area:infrastructure
achimnol
added a commit
that referenced
this pull request
Jun 5, 2023
Backported-from: main Backported-to: 23.03
achimnol
added a commit
that referenced
this pull request
Jun 5, 2023
Backported-from: main Backported-to: 22.09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes plugin discovery failures in
pants testruns after #1317.Though, this approach violates the philosophy of "hermetic" virtualenvs in Pants.
For the plugin discovery in the exported venvs (not
pants test), it could be updated to use[export].py_editable_in_resolvewhich will be introduced in Pants 2.17.