Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add info fields to GQL image schema #2939

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Oct 22, 2024

GQL query example

query ImageList {
    images {
        id
        name
        namespace
        base_image_name
        tags {
            key
            value
        }
        version
        registry
        architecture
    }
}

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

Copy link
Member Author

fregataa commented Oct 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fregataa and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added comp:manager Related to Manager component size:S 10~30 LoC labels Oct 22, 2024
@@ -373,13 +389,14 @@ def from_legacy_image(cls, row: Image) -> ImageNode:
id=row.id,
row_id=row.id,
name=row.name,
namespace=row,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The namespace attribute is being assigned the entire row object, which appears to be an error. This should likely be row.namespace to correctly assign the namespace value. Please verify the intended data structure and update accordingly to ensure proper attribute assignment.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@fregataa fregataa added this to the 24.09 milestone Oct 22, 2024
@fregataa fregataa force-pushed the topic/10-22-feature_add_info_field_to_gql_image_schema branch from e15dfe2 to 66a609e Compare October 22, 2024 09:23
Base automatically changed from topic/10-22-chore_relocate_gql_schema_codes_related_to_image to main October 22, 2024 10:17
@fregataa fregataa force-pushed the topic/10-22-feature_add_info_field_to_gql_image_schema branch 3 times, most recently from 273926f to 97798b2 Compare October 23, 2024 04:32
@fregataa fregataa changed the title feature: Add info fields to GQL image schema feat: Add info fields to GQL image schema Oct 28, 2024
@fregataa fregataa modified the milestones: 24.09, 24.12 Oct 28, 2024
@fregataa fregataa force-pushed the topic/10-22-feature_add_info_field_to_gql_image_schema branch from dfb24b4 to 7233087 Compare October 28, 2024 06:03
@fregataa fregataa marked this pull request as ready for review October 28, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant