Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong parameter when call 'recalc_agent_resource_occupancy()' #2982

Merged

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Oct 25, 2024

manager.models.agent.recalc_agent_resource_occupancy() accepts an SQLAlchemy AsyncSession type object rather than SQLAlchemy AsyncConnection type object.
This causes error since the result of AsyncSession.scalars() and AsyncConnection.scalars() are different

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@fregataa fregataa added this to the 24.03 milestone Oct 25, 2024
@fregataa fregataa self-assigned this Oct 25, 2024
@github-actions github-actions bot added comp:manager Related to Manager component size:S 10~30 LoC labels Oct 25, 2024
@fregataa fregataa modified the milestones: 24.03, 24.09 Oct 25, 2024
@fregataa fregataa added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit a833ccb Oct 25, 2024
21 checks passed
@fregataa fregataa deleted the fix/wrong-param-when-call-recalc-agent-resource-occupancy branch October 25, 2024 09:53
fregataa added a commit that referenced this pull request Oct 25, 2024
…2982)

Backported-from: main (24.12)
Backported-to: 24.09
Backport-of: 2982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant