Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong password limit in container registry migration script #2986

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Oct 28, 2024

Hotfix of #1917 migration script.

Remove the incorrect length restriction applied to the password field in the existing migration script.

Caution

This PR contains updates to a revision script which has already been published to the stable release. Existing clusters operating Backend.AI 24.09 should execute following script to manually elaborate the database schema:

alembic downgrade 20218a73401b
alembic upgrade head

During the process, data inserted to the container_registries.extra column will be wiped out. The column is effective only for AWS ECR, GitLab and GitHub registries; you may safely ignore this warning if you are not engaged with those registries.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@jopemachine jopemachine added the type:bug Reports about that are not working label Oct 28, 2024
@jopemachine jopemachine added this to the 24.09 milestone Oct 28, 2024
@jopemachine jopemachine self-assigned this Oct 28, 2024
@github-actions github-actions bot added comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:XS ~10 LoC labels Oct 28, 2024
@jopemachine jopemachine marked this pull request as ready for review October 28, 2024 05:35
@jopemachine jopemachine changed the title fix: Wrong password limit in containe registry migration script fix: Wrong password limit in container registry migration script Oct 28, 2024
@jopemachine jopemachine added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 68876e5 Oct 28, 2024
25 checks passed
@jopemachine jopemachine deleted the fix/wrong-password-limit branch October 28, 2024 06:03
lablup-octodog pushed a commit that referenced this pull request Oct 28, 2024
…2986)

Backported-from: main (24.12)
Backported-to: 24.09
Backport-of: 2986
github-merge-queue bot pushed a commit that referenced this pull request Oct 28, 2024
…2986) (#2988)

Co-authored-by: Gyubong Lee <jopemachine@naver.com>
Co-authored-by: Kyujin Cho <kyujin.cho@lablup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:XS ~10 LoC type:bug Reports about that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant