fix: CLI test failures caused by yarl.URL._val type change
#3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jopemachine
force-pushed
the
fix/broken-cli-test
branch
from
0f00580 to
66d3f4f
Compare
jopemachine
changed the title
yarl.URL._val type change
2 tasks
jopemachine
changed the title
yarl.URL._val type changeyarl.URL._val type change
achimnol
requested changes
Dec 10, 2024
2 tasks
HyeockJinKim
approved these changes
Dec 12, 2024
achimnol
approved these changes
Dec 12, 2024
lablup-octodog
pushed a commit
that referenced
this pull request
Dec 12, 2024
Backported-from: main (24.12) Backported-to: 24.09 Backport-of: 3235
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
…3244) Co-authored-by: Gyubong Lee <jopemachine@naver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3234.
This is occurring after upgrading dependencies in 8e607b8.
Due to version changes in
yarl, the type of theURL._valhas been changed to a tuple.This PR addresses the side effects caused by this change.
Note
FYI, The code also works when
URL._valis aSplitResult, so it does not cause compatibility issues.Reference
This change was from in yarl 1.17.1,
and aiodocker 0.24.0 requires yarl 1.17.2
(Ref: https://github.com/aio-libs/aiodocker/blob/1cdac6661c0623822d381a0340136b20ce510b62/pyproject.toml#L35)
See https://github.com/aio-libs/yarl/releases?page=1 for details.
Changed PR: aio-libs/yarl#1396
Others
Backend.AI 24.09 uses yarl version 1.13.1, but tests are conducted with version yarl 1.18.3.
So it seems this issue currently occurs only in testing.
How to reproduce
pants test tests/client/cli/test_cli_commands.pyin local.Checklist: (if applicable)