-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement log storage polymorphism #82
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jopemachine
force-pushed
the
feat/implement-memstorage
branch
from
April 20, 2024 06:53
3033214
to
15d592e
Compare
jopemachine
added
log-storage
Log store (Stable storage)
feature
New feature or request
labels
Apr 20, 2024
jopemachine
force-pushed
the
feat/implement-memstorage
branch
from
September 23, 2024 07:54
12e9f12
to
aa84a37
Compare
jopemachine
added
the
refactoring
Rewrite something in better way while keeping the same functionality
label
Sep 27, 2024
jopemachine
force-pushed
the
feat/implement-memstorage
branch
from
September 27, 2024 08:20
e30bc4f
to
b3f9acd
Compare
jopemachine
changed the title
feat: Implement
feat: Implement log storage polymorphism
Sep 27, 2024
MemStorage
Remaining tasks: Python bindings and documentation update. |
jopemachine
force-pushed
the
feat/implement-memstorage
branch
from
September 30, 2024 00:56
ab5b557
to
bad8c80
Compare
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
epic
feature
New feature or request
log-storage
Log store (Stable storage)
refactoring
Rewrite something in better way while keeping the same functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites of #124.
Resolves #85, #133.
MemStorage
for testinglog storage
polymorphismraftify_cli
into a standalone crateraftify_cli
crate is separated into its own crate because it needs to include all storage dependencies.Note: While it is possible to define a PyStorage type in Python to allow for custom storage, it would not perform well, and since no useful examples of its application have been found, we will not proceed with this approach. Instead, let's move the storage object creation logic into the
Raft.bootstrap()
method, and configure theraftify-py
package to build a separate whl file for each storage type during the build process.