Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(main): dev to latest #3482

Merged
merged 1 commit into from
Jul 10, 2023
Merged

build(main): dev to latest #3482

merged 1 commit into from
Jul 10, 2023

Conversation

cuisongliu
Copy link
Collaborator

@cuisongliu cuisongliu commented Jul 10, 2023

🤖 Generated by Copilot at 1be6062

Summary

🏷️🚀📝

This pull request changes the default image tag from dev to latest in various workflows, controllers, and manifests. The purpose of this change is to simplify the image building and deployment process, and to avoid confusion or inconsistency with the dev tag. This change affects the .github/workflows directory, the controllers directory, and some README.md and Makefile files.

We're breaking free from the dev tag
We're using latest for our image flag
We're simplifying our workflows and manifests
We're building and deploying with the best

Walkthrough

  • Change the default value of the push_image_tag input parameter to latest in the cloud, controllers, frontend, and services workflows (link, link, link, link)
  • Remove the type=raw,value=dev,enable=true line from the sealos build command in the controllers, frontend, and services workflows, as the image tag is determined by the push_image_tag input parameter (link, link, link)
  • Modify the TAG variable in the prepare step of the ci-patch-image and webhooks workflows to use latest instead of dev, to align the image tag with the push_image_tag input parameter (link, link)
  • Modify the OLD_DOCKER_IMAGE_NAME variable in the patch-image step of the controllers and services workflows to use latest instead of dev, to match the image tag in the original manifests (link, link)
  • Modify the old_docker_image variable in the prepare step of the frontend workflow to use latest instead of dev, to match the image tag in the original manifests (link)
  • Change the IMG variable in the Makefile of the account, app, cluster, db/adminer, db/bytebase, and imagehub controllers to use latest instead of dev, to match the image tag in the Dockerfile and the manifests (link, link, link, link, link)
  • Change the image field in the manager_auth_proxy_patch.yaml and deploy.yaml of the account controller to use latest instead of dev, to match the image tag in the Makefile (link, link)
  • Change the image field in the deploy.yaml of the app and cluster controllers to use latest instead of dev, to match the image tag in the Makefile (link, link)
  • Change the image field in the deploy.yaml.tmpl of the cloud, db/adminer, and db/bytebase controllers to use latest instead of dev, to match the image tag in the Makefile (link, link, link)
  • Change the sealos build and sealos run commands in the README.md of the db/adminer and db/bytebase controllers to use latest instead of dev, to match the image tag in the Makefile (link, link, link, link)

Signed-off-by: cuisongliu <cuisongliu@qq.com>
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 846
✅ Successful 323
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 522
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (613ce0f) 72.97% compared to head (1be6062) 72.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3482   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files           8        8           
  Lines         618      618           
=======================================
  Hits          451      451           
  Misses        132      132           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cuisongliu cuisongliu merged commit 0c00b99 into labring:main Jul 10, 2023
101 checks passed
@cuisongliu cuisongliu deleted the dev-latest branch July 10, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants