Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update app patch and label key #3546

Merged
merged 4 commits into from
Jul 19, 2023
Merged

update app patch and label key #3546

merged 4 commits into from
Jul 19, 2023

Conversation

c121914yu
Copy link
Collaborator

@c121914yu c121914yu commented Jul 19, 2023

πŸ€– Generated by Copilot at e4a55da

Summary

πŸŒπŸ› οΈβ™»οΈ

This pull request improves the frontend providers applaunchpad module by updating the internationalization files, refactoring the code to use constants, simplifying the labels and messages, fixing some bugs, and changing some terms for clarity and consistency. The changes affect the common.json, editApp.ts, useConfirm.tsx, getApps.ts, updateApp.ts, DelModal.tsx, adapt.ts, deployYaml2Json.ts, app.ts, _app.tsx, AppBaseInfo.tsx, EditEnvs.tsx, Form.tsx, and index.tsx files.

Sing, O Muse, of the skilled and diligent coders
Who updated the applaunchpad with many improvements
They changed the hard-coded strings to constants noble
And made the labels and messages more clear and suitable

Walkthrough

  • Simplify and unify the wording of the buttons and messages related to updating and deploying applications, and use a more appropriate term for alerting the user of potential risks (link, link, link, link, link, link, link)
  • Add and modify the key-value pairs in the common.json files for internationalization, using more concise and accurate terms for some features and labels of the application (link, link, link, link, link, link, link, link, link, link)
  • Add and use the appDeployKey and domainKey constants to replace the hard-coded strings that represent the labels for the application deployment manager and the domain name in the Kubernetes resources (link, link, link, link, link, link, link, link, link, link, link)
  • Change the default language of the application to 'en' instead of 'zh', and add the t function to the dependency array of the useEffect hook that deletes the application (link, link)
  • Change the patch function for the stateful set resource to try to patch it first, and if it fails, then delete and recreate it, to avoid unnecessary deletion and recreation that may cause data loss or downtime (link)
  • Change the patch function for the config map resource to use the applyYamlList function instead of the patchNamespacedConfigMap method, to fix a bug that causes the config map to be corrupted when patching it (link)
  • Change the text node for the confirmation message in the deletion modal from 'Confirm' to 'To Confirm', and use the translated key for the message (link)
  • Change the text node for the label of the external access feature from 'Accessible to the Public' to 'External Access', and use the translated key for the term (link, link)
  • Change the placeholder prop of the text area for the environment variables input to use the translated key for the placeholder text (link)
  • Remove an unused variable declaration and an empty line from the getApps.ts and index.tsx files, respectively, to improve the code style and readability (link, link)
  • Remove an unused type import from the updateApp.ts file, to avoid unnecessary dependencies (link)

@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 908
βœ… Successful 343
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 564
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@zzjin zzjin added this to the v5.0 milestone Jul 19, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (186eae5) 72.97% compared to head (e4a55da) 72.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3546   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files           8        8           
  Lines         618      618           
=======================================
  Hits          451      451           
  Misses        132      132           
  Partials       35       35           

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@zzjin zzjin merged commit 481f9a7 into labring:main Jul 19, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants