Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n and hpa target #3548

Merged
merged 7 commits into from
Jul 20, 2023
Merged

i18n and hpa target #3548

merged 7 commits into from
Jul 20, 2023

Conversation

c121914yu
Copy link
Collaborator

@c121914yu c121914yu commented Jul 20, 2023

🤖 Generated by Copilot at ba36fb6

Summary

🔄📈🌐

This pull request refactors the way the frontend gets the service environment variables from the backend, and fixes some issues with the user interface and the data conversion. It adds a new API handler and function to fetch the SEALOS_DOMAIN and INGRESS_SECRET variables from the backend, and updates the App component and the loadInitData function to use them. It also changes some texts in the common.json file, and adjusts the hpa value calculation in the adaptAppDetail and json2HPA functions.

getInitData fetches
service variables from backend
no more server-side

Walkthrough

  • Replace setServiceEnv function with loadInitData function to fetch service environment variables from backend (link, link, link, link)
  • Remove SEALOS_DOMAIN and INGRESS_SECRET props from App component, as they are no longer needed (link)
  • Add getInitData API function and type to get service environment variables from backend (link, link, link)
  • Change text for "Confirm" button and "jump_message" to make them consistent (link, link)
  • Change text for "Number of Instances" to make it shorter and simpler (link)
  • Convert hpa value from percentage to decimal and vice versa for frontend and backend compatibility (link, link)

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Jul 20, 2023

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 908
✅ Successful 343
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 564
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ed40683) 72.97% compared to head (a347862) 72.97%.

❗ Current head a347862 differs from pull request most recent head 3ea22b6. Consider uploading reports for the commit 3ea22b6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3548   +/-   ##
=======================================
  Coverage   72.97%   72.97%           
=======================================
  Files           8        8           
  Lines         618      618           
=======================================
  Hits          451      451           
  Misses        132      132           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pull-request-size
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@zzjin zzjin added this to the v5.0 milestone Jul 20, 2023
@zzjin zzjin merged commit d4ca6cc into labring:main Jul 20, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants