Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix scripts #4217

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix scripts #4217

merged 1 commit into from
Oct 31, 2023

Conversation

bxy4543
Copy link
Member

@bxy4543 bxy4543 commented Oct 31, 2023 •
edited by ghost
Loading

🤖 Generated by Copilot at cc5a27f

Summary

🛠️🌐🔒

This pull request enhances the scripts/cloud/install.sh script by simplifying the certificate input and ensuring the cilium installation runs in a subshell.

To install the cloud with more ease
We improved the cert input keys
And to make it more stable
We added subshell ( )
To the cilium commands, if you please

Walkthrough

  • Simplify user input logic for certificate and private key paths (link)
  • Execute cilium installation commands as subshell to prevent script exit on failure or skip (link)

@bxy4543 bxy4543 requested a review from lingdie October 31, 2023 10:09
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 970
✅ Successful 377
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 592
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@sweep-ai
Copy link

sweep-ai bot commented Oct 31, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 31, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@lingdie lingdie merged commit 99d65e6 into labring:main Oct 31, 2023
42 of 43 checks passed
lingdie added a commit to lingdie/sealos that referenced this pull request Nov 3, 2023
@lingdie @cuisongliu
@yangchuansheng @zjy365 @Wishrem @bxy4543 @sealos-release-robot @xudaotutou @zzjin
Release ci (#25)
ca5dfca 
* add license app to cloud. (labring#4196)

Signed-off-by: yy <lingdie.yy@outlook.com>

* feature(main): skip sealos.run rule (labring#4198)

* Update README (labring#4197)

Signed-off-by: Carson Yang <yangchuansheng33@gmail.com>

* add cronjob app to cloud. (labring#4201)

Signed-off-by: yy <lingdie.yy@outlook.com>

* fix run init job. (labring#4202)

Signed-off-by: yy <lingdie.yy@outlook.com>

* feat service license (labring#4195)

* feat: license service

Signed-off-by: jingyang <3161362058@qq.com>

* done

* tempalte

Signed-off-by: jingyang <3161362058@qq.com>

* done

Signed-off-by: jingyang <3161362058@qq.com>

* done

Signed-off-by: jingyang <3161362058@qq.com>

* docker build

Signed-off-by: jingyang <3161362058@qq.com>

* done

Signed-off-by: jingyang <3161362058@qq.com>

* license yaml

Signed-off-by: jingyang <3161362058@qq.com>

* image

* fix type bg

* env

* add oss

Signed-off-by: jingyang <3161362058@qq.com>

* done

Signed-off-by: jingyang <3161362058@qq.com>

cluster done

Signed-off-by: jingyang <3161362058@qq.com>

done

Signed-off-by: jingyang <3161362058@qq.com>

cluster done

Signed-off-by: jingyang <3161362058@qq.com>

done cluster

Signed-off-by: jingyang <3161362058@qq.com>

done

Signed-off-by: jingyang <3161362058@qq.com>

* fix build

Signed-off-by: jingyang <3161362058@qq.com>

* fix oss && only zh

Signed-off-by: jingyang <3161362058@qq.com>

* feat checkout wechat

Signed-off-by: jingyang <3161362058@qq.com>

* fix ci

Signed-off-by: jingyang <3161362058@qq.com>

---------

Signed-off-by: jingyang <3161362058@qq.com>

* Docs: update "What is Sealos?" (labring#4200)

Signed-off-by: Carson Yang <yangchuansheng33@gmail.com>

* refactor(main): unmount override container (labring#4161)

Signed-off-by: cuisongliu <cuisongliu@qq.com>

* feat: Create a demo plugin Monitor (labring#4184)

* feat: lens demo of web version

* chore: add & remove some packages

* fix: connect to desktop bug and change icon

* init: plugin Monitor init

* style: restore frontend/pnpm-workspace.yaml & pnpm-lock.yaml and create new ones in plugins/monitor

* restore: frontend/Makefile

* restore: frontend/pnpm-workspace.yaml

* restore

* feat:frontend license app (labring#4203)

* feat:frontend license app

Signed-off-by: jingyang <3161362058@qq.com>

* fix

Signed-off-by: jingyang <3161362058@qq.com>

* fix

* fix detail

Signed-off-by: jingyang <3161362058@qq.com>

---------

Signed-off-by: jingyang <3161362058@qq.com>

* Docs: update introduction (labring#4207)

Signed-off-by: Carson Yang <yangchuansheng33@gmail.com>

* fix license db uri (labring#4211)

Signed-off-by: yy <lingdie.yy@outlook.com>

* update price (labring#4212)

* docs: Automated Changelog Update for v4.3.7 (labring#4210)

* 🤖 add release changelog using robot.

Signed-off-by: sealos-release-robot <sealos-release-robot@sealos.io>

* Update CHANGELOG.md

---------

Signed-off-by: sealos-release-robot <sealos-release-robot@sealos.io>
Co-authored-by: cuisongliu <cuisongliu@qq.com>

* 🤖 add release changelog using rebot. (labring#4213)

* add alt names. (labring#4214)

Signed-off-by: yy <lingdie.yy@outlook.com>

* Update the workflow to automatically update the website image after the image is built (labring#4209)

Signed-off-by: Carson Yang <yangchuansheng33@gmail.com>

* fix(costcenter): fix unit & invoice amount (labring#4194)

* feat:docs add private cloud page (labring#4215)

* fix scripts (labring#4217)

* Fix database provider i18n. (labring#4216)

Signed-off-by: zzjin <tczzjin@gmail.com>

* fix user avator && url (labring#4218)

* fix user avator && url

Signed-off-by: jingyang <3161362058@qq.com>

* modify purchase page

Signed-off-by: jingyang <3161362058@qq.com>

* fix height

Signed-off-by: jingyang <3161362058@qq.com>

* fix docs

Signed-off-by: jingyang <3161362058@qq.com>

* fix params

* copy code

* license time

---------

Signed-off-by: jingyang <3161362058@qq.com>

* fix oss file name && docs footer (labring#4220)

* feat(frontend/desktop):support modify team limit (labring#4221)

* add acme resolver monitoring (labring#4223)

* feat:docs language-differentiated domain names (labring#4226)

* feat:standard cluster purchase process (labring#4225)

* feat:standard cluster purchase process

Signed-off-by: jingyang <3161362058@qq.com>

* fix cronjob

Signed-off-by: jingyang <3161362058@qq.com>

---------

Signed-off-by: jingyang <3161362058@qq.com>

* add cloud release ci.

Signed-off-by: yy <lingdie.yy@outlook.com>

---------

Signed-off-by: yy <lingdie.yy@outlook.com>
Signed-off-by: Carson Yang <yangchuansheng33@gmail.com>
Signed-off-by: jingyang <3161362058@qq.com>
Signed-off-by: cuisongliu <cuisongliu@qq.com>
Signed-off-by: sealos-release-robot <sealos-release-robot@sealos.io>
Signed-off-by: zzjin <tczzjin@gmail.com>
Co-authored-by: cuisongliu <cuisongliu@qq.com>
Co-authored-by: Carson Yang <yangchuansheng33@gmail.com>
Co-authored-by: zhujingyang <72259332+zjy365@users.noreply.github.com>
Co-authored-by: Wishrem <97738578+Wishrem@users.noreply.github.com>
Co-authored-by: Jiahui <4543bxy@gmail.com>
Co-authored-by: sealos-release-robot <sealos-release-robot@sealos.io>
Co-authored-by: xudaotutou <13435638964@163.com>
Co-authored-by: zzjin <zzjin@users.noreply.github.com>
@bxy4543 bxy4543 deleted the fix/scripts_cert_input branch January 5, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lingdie lingdie lingdie approved these changes

Assignees
No one assigned
Labels
area/ci size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bxy4543 @sealos-ci-robot @lingdie