use channel to manage goroutine when upgrade nodes #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix to Info not Alert on drain nodes. add ip in logs to upgrade logs Signed-off-by: oldthreefeng <louisehong4168@gmail.com>
oldthreefeng
commented
Jan 15, 2021
Comment on lines
111
to
+117
| if strings.Contains(str, ApiServer) { | ||
| logger.Info("local %s is already exists %s", etcHostPath, ApiServer) | ||
| return nil | ||
| } | ||
| if err == io.EOF { | ||
| break | ||
| } |
There was a problem hiding this comment.
如果是最后一行， 就直接break了。 所以把判断是否存在放在前面。
| @@ -11,7 +11,7 @@ func (s *SealosInstaller) SendPackage() { | |||
| // rm old sealos in package avoid old version problem. if sealos not exist in package then skip rm | |||
| kubeHook := fmt.Sprintf("cd /root && rm -rf kube && tar zxvf %s && cd /root/kube/shell && rm -f ../bin/sealos && bash init.sh", pkg) | |||
| deletekubectl := `sed -i '/kubectl/d;/sealos/d' /root/.bashrc ` | |||
| completion := "echo 'command -v kubectl &>/dev/null && source <(kubectl completion bash)' >> /root/.bashrc && echo 'command -v sealos &>/dev/null && source <(sealos completion bash)' >> /root/.bashrc && source /root/.bashrc" | |||
| completion := "echo 'command -v kubectl &>/dev/null && source <(kubectl completion bash)' >> /root/.bashrc && echo '[ -x /usr/bin/sealos ] && source <(sealos completion bash)' >> /root/.bashrc && source /root/.bashrc" | |||
There was a problem hiding this comment.
避免 permission deny 的问题。 如果 不能执行 sealos 就不需要执行 补全。
| }(i) | ||
| } | ||
| pool.Wait() | ||
| println(runtime.NumGoroutine()) |
There was a problem hiding this comment.
| @@ -55,7 +55,7 @@ func CordonUnCordon(k8sClient *kubernetes.Clientset, nodeName string, cordoned b | |||
| return err | |||
| } | |||
| if node.Spec.Unschedulable == cordoned { | |||
| logger.Alert("Node %s is already cordoned: %v", nodeName, cordoned) | |||
| logger.Info("Node %s is already Uncordoned, skip...", nodeName) | |||
There was a problem hiding this comment.
如果已经是ready。 则INFO 而不是Alert。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: oldthreefeng louisehong4168@gmail.com
[SKIP CI]seaols: 一句话简短描述该PR内容
升级最多并发升级两个节点.