Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent closing modal & disable input during form submission #124

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

fix: Prevent closing modal & disable input during form submission #124

wants to merge 2 commits into from

Conversation

pawanpaudel93
Copy link
Contributor

Summary

This PR introduces enhancements/fixes aimed at improving user experience during form submissions in modals. Key updates include:

  • Prevention of modal closure during active form submissions.
  • Usage of cursor-not-allowed and input disabling during form submission to indicate processing and prevent user interaction.

How to Test

  • Test different modals: Perform creating repo, forking repo, uploading new files and more to check if the inputs are disabled and user's can't close the modals during active form submissions.

@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
protocol-land ✅ Ready (Inspect) Visit Preview Apr 29, 2024 5:41am

7i7o
7i7o approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@7i7o 7i7o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 🚀

Minor details

  • Upload files can end up in a zombie modal if file upload fails
  • Upload files "Browse File" input is not disabled while submitting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7i7o 7i7o 7i7o approved these changes

@kranthicodes kranthicodes Awaiting requested review from kranthicodes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawanpaudel93 @7i7o