Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return HTTP status 400 if missing JWT #13

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

kitloong
Copy link
Contributor

Fixes

echo-jwt/jwt.go

Lines 159 to 161 in 6944ffe

// For valid token, it sets the user in context and calls next handler.
// For invalid token, it returns "401 - Unauthorized" error.
// For missing token, it returns "400 - Bad Request" error.

https://echo.labstack.com/docs/middleware/jwt

Should return HTTP status 400 if missing JWT as documented.

@kitloong
Copy link
Contributor Author

Hi @aldas

I am sorry, just a kind reminder to review in case you have missed this, thank you!

Copy link
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldas aldas merged commit 2fe4a09 into labstack:main Jul 28, 2023
11 checks passed
@kitloong kitloong deleted the feature/400 branch July 28, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants