Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ip-address.md #296

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Update ip-address.md #296

merged 2 commits into from
Aug 22, 2023

Conversation

mohammadhz98
Copy link
Contributor

TrustIPRanges was wrong. correct it to TrustIPRange. and add example for TrustOptions

`TrustIPRanges` was wrong. correct it to `TrustIPRange`. and add example for TrustOptions
echo.TrustLoopback(false), // e.g. ipv4 start with 127.
echo.TrustLinkLocal(false), // e.g. ipv4 start with 169.254
echo.TrustPrivateNet(false), // e.g. ipv4 start with 10. or 192.168
echo.TrustIPRange(echo.lbIPRange),
Copy link
Contributor

@aldas aldas Aug 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo.lbIPRange should probably be lbIPRange. Other than that - this PR seems ok

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.
thank you

`TrustIPRanges` was wrong. correct it to `TrustIPRange`. and add example for TrustOptions
Copy link
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aldas aldas merged commit 90cc5a8 into labstack:master Aug 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants