Renaming Persist and making sync load

src/CHttp/CommandFactory.cs

@@ -188,7 +188,7 @@ private static void CreateFormsCommand(IWriter? writer,
 			requestDetails = requestDetails with { Content = formContent };
 			await client.SendRequestAsync(requestDetails);
 			await writer.CompleteAsync(CancellationToken.None);
-			await cookieContainer.PersistContainerAsync();
+			await cookieContainer.SaveAsync();
 		},
 		new HttpRequestDetailsBinder(new HttpMethodBinder(methodOptions),
 		  new UriBinder(uriOption),
@@ -225,7 +225,7 @@ private static void CreateDefaultCommand(IWriter? writer,
 			var client = new HttpMessageSender(writer, cookieContainer, httpBehavior);
 			await client.SendRequestAsync(requestDetails);
 			await writer.CompleteAsync(CancellationToken.None);
-			await cookieContainer.PersistContainerAsync();
+			await cookieContainer.SaveAsync();
 		},
 		new HttpRequestDetailsBinder(new HttpMethodBinder(methodOptions),
 		  new UriBinder(uriOption),
@@ -266,7 +266,7 @@ private static void CreateJsonCommand(IWriter? writer,
 			requestDetails = requestDetails with { Content = new StringContent(body) };
 			await client.SendRequestAsync(requestDetails);
 			await writer.CompleteAsync(CancellationToken.None);
-			await cookieContainer.PersistContainerAsync();
+			await cookieContainer.SaveAsync();
 		},
 		new HttpRequestDetailsBinder(new HttpMethodBinder(methodOptions),
 		  new UriBinder(uriOption),

src/CHttp/Http/HttpMessageSender.cs

@@ -25,8 +25,7 @@ public HttpMessageSender(IWriter writer, ICookieContainer cookieContainer, HttpB
 			messageHandler.SslOptions.RemoteCertificateValidationCallback = (_, _, _, _) => true;
 
 		messageHandler.UseCookies = true;
-		messageHandler.CookieContainer = cookieContainer
-			.GetContainerAsync().GetAwaiter().GetResult();
+		messageHandler.CookieContainer = cookieContainer.Load();
 
 		_client = new HttpClient(messageHandler);
 		_client.Timeout = TimeSpan.FromSeconds(behavior.Timeout);

src/CHttp/Http/ICookieContainer.cs

@@ -2,7 +2,7 @@
 
 internal interface ICookieContainer
 {
-	Task<CookieContainer> GetContainerAsync();
+	CookieContainer Load();
 
-	Task PersistContainerAsync();
+	Task SaveAsync();
 }

src/CHttp/Http/PersistentCookieContainer.cs

@@ -10,8 +10,8 @@ internal sealed class PersistentCookieContainer : ICookieContainer
 {
 	private CookieContainer _container = new CookieContainer();
 
-    public PersistentCookieContainer(IFileSystem fileSystem, string name)
-    {
+	public PersistentCookieContainer(IFileSystem fileSystem, string name)
+	{
 		FileSystem = fileSystem;
 		Name = name;
 	}
@@ -20,13 +20,13 @@ public PersistentCookieContainer(IFileSystem fileSystem, string name)
 
 	private string Name { get; }
 
-	public async Task<CookieContainer> GetContainerAsync()
+	public CookieContainer Load()
 	{
 		if (string.IsNullOrWhiteSpace(Name) || !FileSystem.Exists(Name))
 			return _container;
 
 		using var stream = FileSystem.Open(Name, FileMode.Open, FileAccess.Read);
-		var cookieCollection = (await JsonSerializer.DeserializeAsync(stream, KnownJsonType.Default.PersistedCookies)) ?? PersistedCookies.Default;
+		var cookieCollection = JsonSerializer.Deserialize(stream, KnownJsonType.Default.PersistedCookies) ?? PersistedCookies.Default;
 
 		if (cookieCollection.Cookies.Count == 0)
 			return _container;
@@ -37,7 +37,7 @@ public async Task<CookieContainer> GetContainerAsync()
 		return _container;
 	}
 
-	public async Task PersistContainerAsync()
+	public async Task SaveAsync()
 	{
 		if (string.IsNullOrWhiteSpace(Name))
 			return;

src/CHttp/PerformanceMeasureOrchestrator.cs

@@ -81,7 +81,7 @@ private async Task<IEnumerable<Summary>> RunClient(HttpRequestDetails requestDet
 			_progressBar.Set(new Ratio<int>(completed, _requestCount, reaminingTime));
 		}
 		await writer.CompleteAsync(CancellationToken.None);
-		await _cookieContainer.PersistContainerAsync();
+		await _cookieContainer.SaveAsync();
 
 		// Skip the first request as that is warm up.
 		return writer.Summaries.Skip(1);