Fixed: port existing query-string fix (browser). Closes #57

ladjs · Jan 25, 2012 · 42218cb · 42218cb
1 parent d8c2758
commit 42218cb
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/lib/superagent.js b/lib/superagent.js
@@ -554,7 +554,10 @@ var superagent = function(exports){
 
     // querystring
     if ('GET' == this.method && data) {
-      this.url += '?' + exports.serializeObject(data);
+      data = exports.serializeObject(data);
+      this.url += ~this.url.indexOf('?')
+        ? '&' + data
+        : '?' + data;
       data = null;
     }
 

diff --git a/test/test.request.js b/test/test.request.js
@@ -358,6 +358,16 @@ test('GET querystring object', function(next){
   });
 });
 
+test('GET querystring append original', function(next){
+  request
+  .get('/querystring?search=Manny')
+  .send({ range: '1..5' })
+  .end(function(res){
+    assert.eql(res.body, { search: 'Manny', range: '1..5' });
+    next();
+  });
+});
+
 test('GET querystring multiple objects', function(next){
   request
   .get('/querystring')
@@ -372,7 +382,7 @@ test('GET querystring multiple objects', function(next){
 
 test('GET querystring object .get(uri, obj)', function(next){
   request
-  .get('/querystring', { search: 'Manny'})
+  .get('/querystring', { search: 'Manny' })
   .end(function(res){
     assert.eql(res.body, { search: 'Manny' });
     next();