Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for retrying failed CORS requests #1194

Closed
mwolson opened this issue Mar 18, 2017 · 1 comment
Closed

Support for retrying failed CORS requests #1194

mwolson opened this issue Mar 18, 2017 · 1 comment

Comments

@mwolson
Copy link
Contributor

mwolson commented Mar 18, 2017

When using the retry() functionality on a bad connection, the browser can sometimes fail during a CORS OPTIONS request, which currently doesn't get retried. Superagent throws an error with crossDomain: true property in this case. We should retry instead, since the next attempt might succeed.
mwolson pushed a commit to mwolson/superagent that referenced this issue Mar 18, 2017
@tt-mikeolson
Allow crossDomain errors to be retried (ladjs#1194)
d428a34 
When using the retry() functionality on a bad connection, the browser can sometimes fail during a CORS OPTIONS request, which currently doesn't get retried. Superagent throws an error with crossDomain: true property in this case. We should retry instead, since the next attempt might succeed.
mwolson pushed a commit to mwolson/superagent that referenced this issue Mar 18, 2017
Allow crossDomain errors to be retried (ladjs#1194)
471e95e 
When using the retry() functionality on a bad connection, the browser can sometimes fail during a CORS OPTIONS request, which currently doesn't get retried. Superagent throws an error with crossDomain: true property in this case. We should retry instead, since the next attempt might succeed.
mwolson pushed a commit to mwolson/superagent that referenced this issue Mar 18, 2017
Allow crossDomain errors to be retried (ladjs#1194)
e2ac374 
When using the retry() functionality on a bad connection, the browser can sometimes fail during a CORS OPTIONS request, which currently doesn't get retried. Superagent throws an error with crossDomain: true property in this case. We should retry instead, since the next attempt might succeed.
kornelski added a commit that referenced this issue Mar 18, 2017
@kornelski
Merge pull request #1195 from mwolson/retry-crossdomain-errors
acaf84d 
Allow crossDomain errors to be retried (#1194)
@mwolson
Copy link
Contributor Author

mwolson commented Mar 18, 2017

Fixed in acaf84d

@mwolson mwolson closed this as completed Mar 18, 2017
kornelski added a commit that referenced this issue Mar 18, 2017
@kornelski
Merge branch 'master' into gh-pages
991f7d7 
* master:
  v3.5.1
  Quicker test
  docs: Document the retry() method
  Allow crossDomain errors to be retried (#1194)
  Read responseType property from the correct object
  Check for ownProperty before adding header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mwolson