Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicated query params #1199

Closed

Conversation

bwidtmann
Copy link

this bug occurs when using new retry feature and using query params in the URL string instead of passing it via the .query({qs: 'present'}) object.

@kornelski
Copy link
Contributor

kornelski commented Mar 29, 2017

Do you have an example code showing the bug that happens with retry?

This is supported:

request.get().query('arr[]=1').query('arr[]=1')

So this is a breaking change, and the fix must be different.

@bwidtmann
Copy link
Author

request.get('http://www.google.com?bla=1&blup=1).retry(1)

the first request is ok, the second request would be:

http://www.google.com?bla=1&blup=1&bla=1&blup=1

you know what I mean?

@kornelski kornelski mentioned this pull request Mar 29, 2017
@kornelski kornelski closed this Mar 29, 2017
@kornelski
Copy link
Contributor

Thanks. I've made a fix for the root cause in #1200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants