Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported node version to >= 4.0 #1248

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Conversation

jwgoh
Copy link
Contributor

@jwgoh jwgoh commented Jul 11, 2017

@kornelski kornelski merged commit 7e19e77 into ladjs:master Jul 11, 2017
@jwgoh jwgoh deleted the update/engine branch July 12, 2017 03:17
@caicai0
Copy link

caicai0 commented Aug 2, 2017

I used it for loading.
var loadingUrl = [];
function load(url){
loadingUrl.push(url);
superagent.get(url).end(function(err,res){
loadingUrl.remove(url);
//other code
});
}

when I used this load() function too many times for diffrent urls.I find that there are away some urls in loadingUrl.I do not know why

@kornelski
Copy link
Contributor

@caicai0 Try using constructs like Promise.all() or use async/await.

However, please do not post in these comments, as they are about a pull request, which is totally unrelated to your problem.

@ladjs ladjs locked and limited conversation to collaborators Aug 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants